-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed version of @opentelemetry/*
dependencies
#21473
Comments
Related: #21397 |
I agree the current situation is problematic and leads to unexpected behaviour and breakages when upgrading Prisma or OpenTelemetry, and I've run into this myself in the past, so I'll go ahead and mark this as confirmed. |
Having OTEL in peer dependencies means the library will not be installed by default unless the host project is using OTEL. Wouldn't that lead to issues at runtime? Or it should try to understand at runtime if package exists or no, perhaps by using I'd say using open-ended wdyt? |
|
Fixes issues with telemetry prisma#21473 by using non-pinned versions of OTEL libraries.
I take this back as I see prisma is now referring to |
Fixes issues with telemetry prisma#21473 by using non-pinned versions of OTEL libraries. Fixes prisma#21473
Fixes issues with telemetry prisma#21473 by using non-pinned versions of OTEL libraries. Fixes prisma#21473
@opentelemetry/*
dependencies
Is there any movement with this issue? It keeps us back from using otel for prisma in a few legacy services where update of major version of prisma is problematic. |
Fixes issues with telemetry prisma#21473 by using non-pinned versions of OTEL libraries. Fixes prisma#21473
Fixes issues with telemetry prisma#21473 by using non-pinned versions of OTEL libraries. Fixes prisma#21473
Fixes issues with telemetry prisma#21473 by using non-pinned versions of OTEL libraries. Fixes prisma#21473
Fixes issues with telemetry prisma#21473 by using non-pinned versions of OTEL libraries. Fixes prisma#21473
We are yet again not able to reliably update to newer versions of OTEL packages due to pins to older versions within prisma. These are new versions just published by OTEL maintainers:
But prisma is still using 0.49 and 1.22 - we can't upgrade our projects safely due to conflicts and multiple instances of OTEL dependencies. |
Fixes issues with telemetry prisma#21473 by using non-pinned versions of OTEL libraries. Fixes prisma#21473
@maxkomarychev this is now in our dev version It took a while since you brought that up, sorry for that and thanks for your issue & PR 🙏🏼 |
@Jolg42 thank you! |
Bug description
Currently prisms locks versions of OTEL libraries:
This creates problem with hoisting: if there are other versions of OTEL libs required in the project package manager will end up installing two copies of "@opentelemetry/api" in order to satisfy constraints:
node_modules
node_modules/<another_package>/node_modules
This will make either external or internal consumers of prisma to receive no-op implementation of a tracer.
How to reproduce
Expected behavior
A package should keep versions of it's dependencies as open as possible https://github.com/prisma/prisma/blob/811babfebbd8c573109f0dc083634bc2e865a87e/packages/instrumentation/package.json
Prisma information
// Add your schema.prisma
// Add your code using Prisma Client
Environment & setup
Prisma Version
The text was updated successfully, but these errors were encountered: