Database classification mismatch

[divyenduz]

We implemented database classification in #2424

Bug description

It misclassified two databases

Database	Introspected Classification	Expected Classification	Database SQL
mysql_127/facebook	Prisma11	NonPrisma	https://gist.github.com/divyenduz/cb716450316227f8531d692b605d8fe7
prisma1-old/p1_demo_us_financeapp	Prisma2	Prisma1	https://github.com/prisma/prisma1-schemas/blob/master/mysql/datamodel_1.1/p1_demo_us_financeapp/schema.sql

How to reproduce

1. Introspect the databases from the above table with a Prisma CLI version that outputs the database classification.

[janpio]

• mysql_127/facebook is recognized as NonPrisma now: https://github.com/prisma/introspection-engine-output/blob/90793328e4e76c547b95757fedb520b6249dbdc4/introspection-analysis/output/mysql_127/Facebook.log

[ryands17]

Related discussion: #2647

[do4gr]

The finance_app one is now correctly identified.

The Facebook one is currently being identified as P11 incorrectly, but it contains so little information that it could be P11.

I would therefore close this.

model edges {
  id1                  Int
  id2                  Int
  feat_edges_id1Tofeat feat @relation("edges_id1Tofeat", fields: [id1], references: [id])
  feat_edges_id2Tofeat feat @relation("edges_id2Tofeat", fields: [id2], references: [id])

  @@id([id1, id2])
  @@index([id2], name: "edges_field2_fkey")
}

model feat {
  birthday1             Int?
  birthday2             Int?
  birthday3             Int?
  birthday4             Int?
  birthday5             Int?
  birthday6             Int?
  birthday7             Int?
  birthday8             Int?
  education1            Int?
  education10           Int?
  education11           Int?
  education12           Int?
  education13           Int?
  education14           Int?
  education15           Int?
  education16           Int?
  education17           Int?
  education18           Int?
  education19           Int?
  education2            Int?
  education20           Int?
  education21           Int?
  education22           Int?
  education23           Int?
  education24           Int?
  education25           Int?
  education26           Int?
  education27           Int?
  education28           Int?
  education29           Int?
  education3            Int?
  education30           Int?
  education31           Int?
  education32           Int?
  education33           Int?
  education34           Int?
  education35           Int?
  education36           Int?
  education37           Int?
  education38           Int?
  education39           Int?
  education4            Int?
  education40           Int?
  education41           Int?
  education42           Int?
  education43           Int?
  education44           Int?
  education45           Int?
  education46           Int?
  education47           Int?
  education48           Int?
  education49           Int?
  education5            Int?
  education50           Int?
  education51           Int?
  education52           Int?
  education53           Int?
  education54           Int?
  education55           Int?
  education56           Int?
  education57           Int?
  education58           Int?
  education59           Int?
  education6            Int?
  education60           Int?
  education61           Int?
  education62           Int?
  education63           Int?
  education64           Int?
  education65           Int?
  education66           Int?
  education67           Int?
  education68           Int?
  education69           Int?
  education7            Int?
  education70           Int?
  education71           Int?
  education72           Int?
  education73           Int?
  education74           Int?
  education75           Int?
  education76           Int?
  education77           Int?
  education78           Int?
  education79           Int?
  education8            Int?
  education80           Int?
  education81           Int?
  education82           Int?
  education83           Int?
  education84           Int?
  education85           Int?
  education86           Int?
  education87           Int?
  education88           Int?
  education89           Int?
  education9            Int?
  education90           Int?
  education91           Int?
  education92           Int?
  education93           Int?
  education94           Int?
  education95           Int?
  education96           Int?
  education97           Int?
  education98           Int?
  education99           Int?
  first_name1           Int?
  first_name10          Int?
  first_name2           Int?
  first_name3           Int?
  first_name4           Int?
  first_name5           Int?
  first_name6           Int?
  first_name7           Int?
  first_name8           Int?
  first_name9           Int?
  gender1               Int?
  gender2               Int?
  hometown1             Int?
  hometown10            Int?
  hometown11            Int?
  hometown2             Int?
  hometown3             Int?
  hometown4             Int?
  hometown5             Int?
  hometown6             Int?
  hometown7             Int?
  hometown8             Int?
  hometown9             Int?
  id                    Int     @id
  languages1            Int?
  languages10           Int?
  languages11           Int?
  languages12           Int?
  languages2            Int?
  languages3            Int?
  languages4            Int?
  languages5            Int?
  languages6            Int?
  languages7            Int?
  languages8            Int?
  languages9            Int?
  last_name1            Int?
  last_name10           Int?
  last_name11           Int?
  last_name12           Int?
  last_name13           Int?
  last_name14           Int?
  last_name15           Int?
  last_name16           Int?
  last_name17           Int?
  last_name18           Int?
  last_name19           Int?
  last_name2            Int?
  last_name20           Int?
  last_name21           Int?
  last_name22           Int?
  last_name23           Int?
  last_name24           Int?
  last_name25           Int?
  last_name26           Int?
  last_name27           Int?
  last_name28           Int?
  last_name29           Int?
  last_name3            Int?
  last_name30           Int?
  last_name4            Int?
  last_name5            Int?
  last_name6            Int?
  last_name7            Int?
  last_name8            Int?
  last_name9            Int?
  locale1               Int?
  locale2               Int?
  locale3               Int?
  locale4               Int?
  locale5               Int?
  location1             Int?
  location10            Int?
  location11            Int?
  location12            Int?
  location13            Int?
  location14            Int?
  location15            Int?
  location16            Int?
  location2             Int?
  location3             Int?
  location4             Int?
  location5             Int?
  location6             Int?
  location7             Int?
  location8             Int?
  location9             Int?
  name1                 Int?
  work1                 Int?
  work10                Int?
  work11                Int?
  work12                Int?
  work13                Int?
  work14                Int?
  work15                Int?
  work16                Int?
  work17                Int?
  work18                Int?
  work19                Int?
  work2                 Int?
  work20                Int?
  work21                Int?
  work22                Int?
  work23                Int?
  work24                Int?
  work25                Int?
  work26                Int?
  work27                Int?
  work28                Int?
  work29                Int?
  work3                 Int?
  work30                Int?
  work31                Int?
  work32                Int?
  work33                Int?
  work34                Int?
  work35                Int?
  work36                Int?
  work37                Int?
  work38                Int?
  work39                Int?
  work4                 Int?
  work40                Int?
  work41                Int?
  work42                Int?
  work43                Int?
  work44                Int?
  work45                Int?
  work46                Int?
  work47                Int?
  work48                Int?
  work49                Int?
  work5                 Int?
  work50                Int?
  work51                Int?
  work52                Int?
  work53                Int?
  work54                Int?
  work55                Int?
  work56                Int?
  work57                Int?
  work58                Int?
  work59                Int?
  work6                 Int?
  work60                Int?
  work61                Int?
  work62                Int?
  work63                Int?
  work64                Int?
  work65                Int?
  work66                Int?
  work67                Int?
  work68                Int?
  work7                 Int?
  work8                 Int?
  work9                 Int?
  edges_edges_id1Tofeat edges[] @relation("edges_id1Tofeat")
  edges_edges_id2Tofeat edges[] @relation("edges_id2Tofeat")
}

[do4gr]

I'm closing this. If we get other reports of misclassification that are more actionable we'll look at them separately.