Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema validation: disallow static empty values #3631

Open
steebchen opened this issue Dec 17, 2019 · 0 comments
Open

schema validation: disallow static empty values #3631

steebchen opened this issue Dec 17, 2019 · 0 comments
Labels
domain/client Issue in the "Client" domain: Prisma Client, Prisma Studio etc. kind/improvement An improvement to existing feature and code. topic: schema validation topic: schema

Comments

@steebchen
Copy link
Contributor

Due to prisma/prisma-client-js#318, we should disallow static empty values, such as:

datasource db {
	provider = "sqlite"
	url      = ""
}

This is usually a mistake by the user. It should throw an error that an empty string is not allowed, because otherwise the user will run into a different, most likely unclear error.

Maybe we could even apply this behavior for all empty static strings, not just datasource.url.

@janpio janpio transferred this issue from prisma/specs Sep 12, 2020
@janpio janpio added kind/improvement An improvement to existing feature and code. team/product topic: schema labels Sep 12, 2020
@pantharshit00 pantharshit00 added the domain/client Issue in the "Client" domain: Prisma Client, Prisma Studio etc. label Apr 22, 2021
@janpio janpio changed the title schema: disallow static empty values schema validation: disallow static empty values Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain/client Issue in the "Client" domain: Prisma Client, Prisma Studio etc. kind/improvement An improvement to existing feature and code. topic: schema validation topic: schema
Projects
None yet
Development

No branches or pull requests

3 participants