Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SKIP_GENERATE from Client postinstall script to PRISMA_SKIP_POSTINSTALL_GENERATE #6151

Closed
Jolg42 opened this issue Mar 17, 2021 · 1 comment · Fixed by #6298
Closed

Rename SKIP_GENERATE from Client postinstall script to PRISMA_SKIP_POSTINSTALL_GENERATE #6151

Jolg42 opened this issue Mar 17, 2021 · 1 comment · Fixed by #6298
Assignees
@Jolg42
Labels
team/client Issue for team Client. tech/typescript Issue for tech TypeScript. topic: prisma-client
Milestone
2.20.0

Comments

@Jolg42
Copy link
Member

Jolg42 commented Mar 17, 2021 •
edited

Problem

prisma/src/packages/client/scripts/postinstall.js

Line 151 in aac667e

if (!process.env.SKIP_GENERATE) {

We should prefix this like the other env var with PRISMA_

Suggested solution

PRISMA_SKIP_POSTINSTALL_GENERATE

Additional context

Migrate has an env var called MIGRATE_SKIP_GENERATE (not prefixed with PRISMA_) that could be renamed too
@Jolg42 Jolg42 added process/candidate tech/typescript Issue for tech TypeScript. team/client Issue for team Client. labels Mar 17, 2021
@Jolg42 Jolg42 mentioned this issue Mar 17, 2021
Merged
@Jolg42 Jolg42 added this to the 2.20.0 milestone Mar 17, 2021
@Jolg42 Jolg42 self-assigned this Mar 17, 2021
@Jolg42 Jolg42 changed the title Rename SKIP_GENERATE from Client postinstall script to PRISMA_CLIENT_SKIP_GENERATE Rename SKIP_GENERATE from Client postinstall script to PRISMA_CLI_SKIP_GENERATE Mar 17, 2021
@Jolg42 Jolg42 changed the title Rename SKIP_GENERATE from Client postinstall script to PRISMA_CLI_SKIP_GENERATE Rename SKIP_GENERATE from Client postinstall script to PRISMA_CLIENT_SKIP_GENERATE Mar 17, 2021
@Jolg42 Jolg42 changed the title Rename SKIP_GENERATE from Client postinstall script to PRISMA_CLIENT_SKIP_GENERATE Rename SKIP_GENERATE from Client postinstall script to PRISMA_SKIP_POSTINSTALL_GENERATE Mar 17, 2021
@Iamshankhadeep
Copy link
Contributor

hey @Jolg42 can I work on this?

@Iamshankhadeep Iamshankhadeep mentioned this issue Mar 26, 2021
Closed
Jolg42 added a commit that referenced this issue Mar 29, 2021
@Jolg42
refactor(client,migrate,sdk): rename/prefix env vars with PRISMA_
ae02f5d 
Closes #6151
@Jolg42 Jolg42 mentioned this issue Mar 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jolg42 Jolg42

Labels
team/client Issue for team Client. tech/typescript Issue for tech TypeScript. topic: prisma-client
Projects
None yet
Milestone
2.20.0
2 participants
@Jolg42 @Iamshankhadeep