-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQL Server: "Flushing unhandled packet from the wire. Please consume your streams!" #7477
Comments
@pimeys could it be the fabled cancellation problem? |
It's not really a problem if the connection doesn't break and turn unusable. If we only get these warnings, the system works as designed. Or, this is an issue where we read only one row and do not consume what is left in the wire. I doubt we have code like that anywhere. The problem this warning causes is that before running another query, we must flush the old data from the stream. So you share a bit of throughput between queries. |
So, as I explained in the other ticket, the warnings are not a problem, handling of some weird collation from non-utf columns is. |
Please change the warning to something that tells users to report this as an issue and does not require me or anyone else to accidentally notice it via another issue. Thanks. |
Notes from internal discussion: The log message is from tiberius, and only happens when we (as tiberius users) did not implement something properly - which was the case above because of a bug we had. In theory this could happen again in the future though, and then again our logs would have this tiberius log without any context. Even if the tiberius log is modified to include a link to create an issue etc, this will be pretty confusing. A "solution" we talked about was to prefix the log messages with where they were coming from in the log output. |
After discussing it with the team we landed on it being not GA-blocking material although something we should indeed fix. |
See
DEBUG=*
log output at #7476 (comment):Related code: https://github.com/prisma/tiberius/blob/56d3b482be9ad17d2472382713c55af4afe32ce2/src/client/connection.rs#L191
The text was updated successfully, but these errors were encountered: