Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo "skip flaky referentialActions sql server test" #7936

Closed
Tracked by #11441
janpio opened this issue Jun 29, 2021 · 2 comments · Fixed by #14758
Closed
Tracked by #11441

Undo "skip flaky referentialActions sql server test" #7936

janpio opened this issue Jun 29, 2021 · 2 comments · Fixed by #14758
Assignees
@Jolg42
Labels
kind/tech A technical change. team/schema Issue for team Schema. topic: referential actions topic: referentialIntegrity/relationMode topic: sql server Microsoft SQL Server
Milestone
4.3.0

Comments

@janpio
Copy link
Member

janpio commented Jun 29, 2021

#7907
@janpio janpio added process/candidate kind/tech A technical change. topic: sql server Microsoft SQL Server team/schema Issue for team Schema. topic: referential actions labels Jun 29, 2021
@janpio janpio mentioned this issue Jun 29, 2021
Merged
@janpio janpio mentioned this issue Jul 1, 2022
Closed
35 tasks
@janpio
Copy link
Member Author

janpio commented Jul 28, 2022

This might already have happened?
https://github.com/prisma/prisma/blob/main/packages/client/src/__tests__/integration/happy/referentialActions-onDelete-cascade-sqlserver/test.ts

@Jolg42 Jolg42 self-assigned this Aug 11, 2022
@Jolg42
Copy link
Member

Jolg42 commented Aug 11, 2022

This is not the same test.

It is still skipped here
https://github.com/prisma/prisma/blob/main/packages/client/src/__tests__/integration/errors/referentialActions-onDelete-default-foreign-key-error-sqlserver/test.ts#L7-L10

I'll open a PR

@Jolg42 Jolg42 added this to the 4.3.0 milestone Aug 11, 2022
Jolg42 added a commit that referenced this issue Aug 11, 2022
@Jolg42
test(client): unskip 1 sqlserver test
049b305 
> referentialActions-onDelete-default-foreign-key-error(sqlserver)
Closes #7936
@Jolg42 Jolg42 mentioned this issue Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jolg42 Jolg42

Labels
kind/tech A technical change. team/schema Issue for team Schema. topic: referential actions topic: referentialIntegrity/relationMode topic: sql server Microsoft SQL Server
Projects
None yet
Milestone
4.3.0
Development

Successfully merging a pull request may close this issue.

test(client): unskip 1 sqlserver test prisma/prisma
3 participants
@janpio @Jolg42 @tomhoule