Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postinstall generate failure error message might be misleading #8066

Closed
janpio opened this issue Jul 4, 2021 · 2 comments
Closed

Postinstall generate failure error message might be misleading #8066

janpio opened this issue Jul 4, 2021 · 2 comments
Labels
domain/client Issue in the "Client" domain: Prisma Client, Prisma Studio etc. kind/improvement An improvement to existing feature and code. tech/typescript Issue for tech TypeScript. topic: error topic: postinstall

Comments

@janpio
Copy link
Contributor

janpio commented Jul 4, 2021

remote:        Environment variables loaded from .env
remote:        Prisma schema loaded from prisma/schema.prisma
remote:        info The postinstall script automatically ran `prisma generate`, which failed.
remote:        The postinstall script still succeeds but won't generate the Prisma Client.
remote:        Please run `prisma generate` to see the errors.

Does this actually mean it ran prisma generate? Or did it run the same code that would run when running the appropriate prisma generate command?

If so, we should find a better way to express this. The current working leads people to investigate what happens when you run prisma generate, which often will indeed be a failure (but for very other reasons): #8065 (comment)

@janpio janpio added bug/0-unknown Bug is new, does not have information for reproduction or reproduction could not be confirmed. kind/bug A reported bug. tech/typescript Issue for tech TypeScript. domain/client Issue in the "Client" domain: Prisma Client, Prisma Studio etc. topic: postinstall topic: error labels Jul 4, 2021
@pantharshit00
Copy link
Contributor

I would mark this as an improvement instead.

@pantharshit00 pantharshit00 added kind/improvement An improvement to existing feature and code. and removed bug/0-unknown Bug is new, does not have information for reproduction or reproduction could not be confirmed. kind/bug A reported bug. labels Jun 2, 2022
@janpio
Copy link
Contributor Author

janpio commented Jun 3, 2022

Does this actually mean it ran prisma generate? Or did it run the same code that would run when running the appropriate prisma generate command?

Current code indeed runs prisma generate but via the CLI script (or global prisma binary if no local script exists in dependencies), not npx prisma or similar - but that should be close enough.

@janpio janpio closed this as not planned Won't fix, can't repro, duplicate, stale Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain/client Issue in the "Client" domain: Prisma Client, Prisma Studio etc. kind/improvement An improvement to existing feature and code. tech/typescript Issue for tech TypeScript. topic: error topic: postinstall
Projects
None yet
Development

No branches or pull requests

2 participants