Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(client): add tests for buildNFTAnnotations #11954

Merged
merged 4 commits into from
Mar 11, 2022
Merged

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Feb 21, 2022

@aqrln aqrln added this to the 3.10.0 milestone Feb 21, 2022
@Jolg42
Copy link
Member

Jolg42 commented Feb 21, 2022

Looks like tests are failing on Windows
https://github.com/prisma/prisma/runs/5276157538?check_suite_focus=true#step:11:1727

    - Snapshot  - 2
    + Received  + 2

      ↵
      path.join(__dirname, "libquery_engine-TEST_PLATFORM.LIBRARY_TYPE.node");
    - path.join(process.cwd(), "out/libquery_engine-TEST_PLATFORM.so.node")
    + path.join(process.cwd(), "out//libquery_engine-TEST_PLATFORM.so.node")
      path.join(__dirname, "schema.prisma");
    - path.join(process.cwd(), "out/schema.prisma")
    + path.join(process.cwd(), "out//schema.prisma")

The double slash // doesn't look good we should check and understand what's going on here, and potentially revert the original PR @aqrln @millsp

@aqrln
Copy link
Member Author

aqrln commented Feb 21, 2022

@Jolg42

The double slash // doesn't look good we should check and understand what's going on here, and potentially revert the original PR @aqrln @millsp

It's because of our snapshot serializer, it always replaces backslashes with forward slashes on Windows, sometimes even outside of file names (some tests are skipped on Windows because of it).

That said, if the snapshot serializer didn't replace them here, the snapshots would still fail because of double backslashes.

@Jolg42 Jolg42 modified the milestones: 3.10.0, 3.11.0 Feb 24, 2022
@aqrln aqrln force-pushed the aqrln/nft-annotations-test branch from 4e14f47 to 1e58647 Compare March 2, 2022 15:49
@aqrln
Copy link
Member Author

aqrln commented Mar 2, 2022

Rebased and added a comment, please take another look.

@Jolg42 Jolg42 merged commit 06f04d2 into main Mar 11, 2022
@Jolg42 Jolg42 deleted the aqrln/nft-annotations-test branch March 11, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants