Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): orderBy for composite types #12004

Merged
merged 17 commits into from
Mar 1, 2022
Merged

feat(client): orderBy for composite types #12004

merged 17 commits into from
Mar 1, 2022

Conversation

millsp
Copy link
Member

@millsp millsp commented Feb 23, 2022 •
edited

@millsp millsp changed the title chore: bump engines feat(client): orderBy for composite types Feb 25, 2022
@millsp millsp marked this pull request as ready for review February 25, 2022 12:07
@Jolg42
Copy link
Member

Jolg42 commented Feb 25, 2022

I don't see any issue related to this, could you check if there is one or create it?

@millsp millsp added this to the 3.11.0 milestone Feb 25, 2022
@millsp millsp linked an issue Feb 25, 2022 that may be closed by this pull request
Integrate orderBy for composite types #12038
Closed
@millsp millsp removed a link to an issue Feb 25, 2022
Integrate orderBy for composite types #12038
Closed
@millsp millsp mentioned this pull request Feb 25, 2022
Closed
@Jolg42 Jolg42 mentioned this pull request Feb 28, 2022
Closed
@Jolg42 Jolg42 mentioned this pull request Feb 28, 2022
Closed
@prisma prisma deleted a comment Feb 28, 2022
Jolg42
Jolg42 approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

See comment about Jest config

@millsp millsp merged commit 39a7862 into main Mar 1, 2022
@millsp millsp deleted the chore/composite-order-by branch March 1, 2022 14:58
aqrln
aqrln reviewed Mar 2, 2022
View reviewed changes
Copy link
Member

@aqrln aqrln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retroactive LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jolg42 Jolg42 Jolg42 approved these changes

@aqrln aqrln aqrln left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.

Implement order by composites
3 participants
@millsp @Jolg42 @aqrln