-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(buildpulse): Cross-platform GitHub Action #12062
Conversation
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com> Co-authored-by: Jason Rudolph <jason@jasonrudolph.com>
That seems to be working fine @jasonrudolph. |
Great! I spot-checked the data on the @buildpulse back-end as well, and everything looks good. 👍 Thanks for setting this up, @janpio. 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that BuildPulseLLC/buildpulse-action#3 is merged, you can use the action's main
branch instead of the temporary cross-platform
branch, so I've suggested those edits in the review below.
I hope this helps.
Co-authored-by: Jason Rudolph <jason@jasonrudolph.com>
@janpio Can we merge this? |
We have 3 failing tests, but they should not be influenced by this really, so if that is just generaly flakyness: Yes. |
Yes, it's unrelated, then, merging now ✔️ |
Follow up to #12054
@jasonrudolph