fix(dataproxy): remove 3.4.1 fallback from DataProxy Client #12738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
janpio
commented
Apr 25, 2022
This comment was marked as outdated.
This comment was marked as outdated.
aqrln
reviewed
Apr 25, 2022
This comment was marked as outdated.
This comment was marked as outdated.
janpio
commented
Apr 25, 2022
packages/client/src/__tests__/getPrismaClient.dataproxy.test.ts
Outdated
Show resolved
Hide resolved
janpio
commented
Apr 25, 2022
janpio
commented
Apr 25, 2022
janpio
commented
Apr 25, 2022
Jolg42
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
aqrln
reviewed
May 25, 2022
janpio
commented
May 31, 2022
| } | ||
| } else { | ||
| throw new NotImplementedYetError( | ||
| 'clientVersion or `PRISMA_CLIENT_DATA_PROXY_CLIENT_VERSION` env var needs to be set with a `major.minor.patch` version for Prisma Data Proxy.', |
There was a problem hiding this comment.
Where would I set the clientVersion myself?
Is that the PDP use case?
|
The 5 new tests are currently failing: |
|
To be replaced by #13629 |
1 similar comment
|
To be replaced by #13629 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Data Proxy Client in PDP Data Browser used to fall back to
3.4.1because of customization of the Client version (it was set tonot-providedinstead of a version) silently becuase of the code that is changed here. After this change, that should fail visibly instead and hopefully surface these cases better.Also introduces
PRISMA_CLIENT_DATA_PROXY_CLIENT_VERSIONto override the version that the Data Proxy should choose, no matter what Client version is used. This will make the Data Proxy (more) usable withdevversions of Prisma Client.