-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: added support for additional cockroachdb tests #13537
Conversation
Note: merging #13547 is necessary to make this PR's MacOS tests succeed. |
packages/migrate/src/__tests__/fixtures/schema-only-cockroachdb/prisma/shadowdb.prisma
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, and tests seem to be passing.
(Some actual TS developer should review besides me before merge though)
Also see questions and comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. More tests are better than no tests, especially if they're green. Code quality looks decent to me.
0941d34
to
cda37d5
Compare
This PR adds cockroachdb tests for:
Closes #13268