New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(engine-core): data proxy integration patch version resolver #13699
Conversation
Related |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried a few to check
https://unpkg.com/prisma@%3C=3.9.2-dev.1/package.json returns 3.9.2-dev.1
🔴 expected 3.9.1
https://unpkg.com/prisma@%3C=3.9.2-dev.2/package.json returns 3.9.2-dev.2
🔴 expected 3.9.1
https://unpkg.com/prisma@%3C=3.9.1-dev.1/package.json returns 3.9.1-dev.1
🔴 expected 3.9.0
If I remove the =
in <=
https://unpkg.com/prisma@%3C3.9.2-dev.1/package.json returns 3.9.1
🟢 expected 3.9.1
https://unpkg.com/prisma@%3C3.9.2-dev.2/package.json returns 3.9.2-dev.1
🔴 expected 3.9.1
https://unpkg.com/prisma@%3C3.9.1-dev.1/package.json returns 3.9.0
🟢 expected 3.9.0
So this works better for patches here but only for the first patch-dev version.
For dev versions it's the same
https://unpkg.com/prisma@%3C3.16.0-dev.14/package.json returns 3.16.0-dev.13
🔴 expected 3.15.0
https://unpkg.com/prisma@%3C3.16.0-dev.1/package.json 3.15.0
🟢 expected 3.15.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh ok you remove the suffix when sending the url to make it work 😓
See suggestion to improve comment
Note if we use |
Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
It's out in |
Fixes the automatic data proxy version resolution for
patch-dev
releases.