Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine-core): data proxy integration patch version resolver #13699

Merged
merged 4 commits into from Jun 9, 2022

Conversation

millsp
Copy link
Member

@millsp millsp commented Jun 8, 2022

Fixes the automatic data proxy version resolution for patch-dev releases.

@millsp millsp requested review from a team, danstarns and Jolg42 and removed request for a team June 8, 2022 13:05
@Jolg42 Jolg42 added this to the 4.0.x milestone Jun 8, 2022
@Jolg42
Copy link
Member

Jolg42 commented Jun 8, 2022

Related 3.15.1-dev.1 2 tests failures for dataproxy
https://prisma-company.slack.com/archives/CRGDU19K6/p1654689974210099

@millsp millsp closed this Jun 8, 2022
@millsp millsp deleted the fix/data-proxy-integration-version branch June 8, 2022 13:39
@millsp millsp restored the fix/data-proxy-integration-version branch June 8, 2022 20:12
@millsp millsp reopened this Jun 8, 2022
Copy link
Member

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried a few to check

https://unpkg.com/prisma@%3C=3.9.2-dev.1/package.json returns 3.9.2-dev.1 🔴 expected 3.9.1
https://unpkg.com/prisma@%3C=3.9.2-dev.2/package.json returns 3.9.2-dev.2 🔴 expected 3.9.1
https://unpkg.com/prisma@%3C=3.9.1-dev.1/package.json returns 3.9.1-dev.1 🔴 expected 3.9.0

If I remove the = in <=

https://unpkg.com/prisma@%3C3.9.2-dev.1/package.json returns 3.9.1 🟢 expected 3.9.1
https://unpkg.com/prisma@%3C3.9.2-dev.2/package.json returns 3.9.2-dev.1 🔴 expected 3.9.1
https://unpkg.com/prisma@%3C3.9.1-dev.1/package.json returns 3.9.0 🟢 expected 3.9.0

So this works better for patches here but only for the first patch-dev version.

For dev versions it's the same

https://unpkg.com/prisma@%3C3.16.0-dev.14/package.json returns 3.16.0-dev.13 🔴 expected 3.15.0
https://unpkg.com/prisma@%3C3.16.0-dev.1/package.json 3.15.0 🟢 expected 3.15.0

Copy link
Member

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok you remove the suffix when sending the url to make it work 😓

See suggestion to improve comment

@Jolg42
Copy link
Member

Jolg42 commented Jun 9, 2022

Note if we use <= then we could get different results once a release happen, before the release happens the previous version will be chosen and after the current one, just something to be aware of I guess.

millsp and others added 2 commits June 9, 2022 10:42
Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
@millsp millsp merged commit 89c1288 into main Jun 9, 2022
@millsp millsp deleted the fix/data-proxy-integration-version branch June 9, 2022 09:18
@Jolg42
Copy link
Member

Jolg42 commented Jun 9, 2022

It's out in 3.16.0-dev.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants