New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): improved error reporting by adding detail to getConfig and getDmmf error #13736
Conversation
…ail-errors-on-panics
…sma/prisma into feat/detail-errors-on-panics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some snapshot updates or test differentiation based on engine type required it seems
Looks good but I can see tests are failing in
and in
I guess it's because there is only one snapshot for library and engine and we need to do something here |
packages/internals/src/__tests__/engine-commands/queryEngineCommons.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one with the spy/mock tests!
See last comment about a test before merging 🚢
…mmons.test.ts Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
Is there an issue this can close so this can appear in the issue list in our release notes? |
This PR closes #14006 |
Improve error reporting occurring in #13717.