Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(client): reproduction for #16423 m:n dangling pivot table entry after deleting #16428

Merged
merged 2 commits into from Nov 24, 2022
Merged

test(client): reproduction for #16423 m:n dangling pivot table entry after deleting #16428

merged 2 commits into from Nov 24, 2022

Conversation

Jolg42
Copy link
Member

@Jolg42 Jolg42 commented Nov 24, 2022

Closes #16423

@Jolg42 Jolg42 added this to the 4.7.0 milestone Nov 24, 2022
@Jolg42 Jolg42 requested review from a team, SevInf and jkomyno and removed request for a team November 24, 2022 09:53
jkomyno
jkomyno approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@jkomyno jkomyno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, but I would probably invert the assertion of these newly added tests with a describe.failing block. Once the client team fixes the underlying issues in query-engine, removing .failing should make this test green again. Agree?

@Jolg42
Copy link
Member Author

Jolg42 commented Nov 24, 2022

I also thought about this, but I wanted to test the foreignKeys behavior at the same time to highlight the difference
I added an explicit TODO comment to remove the conditional once the bug is fixed.

@Jolg42 Jolg42 merged commit 299f2a3 into main Nov 24, 2022
@Jolg42 Jolg42 deleted the joel/repro-16423 branch November 24, 2022 11:32
jkomyno pushed a commit that referenced this pull request Dec 21, 2022
@Jolg42 @jkomyno
test(client): reproduction for #16423 m:n dangling pivot table entry …
4f85f65 
…after deleting (#16428)

* test(client): reproduction for #16423 m:n dangling pivot table entry after deleting

Closes #16423

* Update packages/client/tests/functional/issues/16390-relation-mode-m-n-dangling-pivot/tests.ts

[skip ci]
jkomyno pushed a commit that referenced this pull request Dec 21, 2022
@Jolg42 @jkomyno
test(client): reproduction for #16423 m:n dangling pivot table entry …
96dc9bc 
…after deleting (#16428)

* test(client): reproduction for #16423 m:n dangling pivot table entry after deleting

Closes #16423

* Update packages/client/tests/functional/issues/16390-relation-mode-m-n-dangling-pivot/tests.ts

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkomyno jkomyno jkomyno approved these changes

@SevInf SevInf Awaiting requested review from SevInf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

Test implicit m:n in relation mode prisma / Reproduction test for prisma#16390
2 participants
@Jolg42 @jkomyno