fix(client): Fix exponenetial regexp in error formatting code #17907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SevInf
requested review from
a team and
aqrln
and removed request for
a team
SevInf
changed the title
In order to render the fancy error message, we try to find a known prisma call in the source code. To do so, we use a reg exp, which turned out to be of exponential complexity. To make matters worth, embedded DMMF in client prior to 4.0.0 could actually trigger exponential backgtracking by itself. Fix #12355
SevInf
force-pushed
the
fix/err-redos
branch
from
3ca0eed
to
59d569a
Compare
aqrln
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to render the fancy error message, we try to find a known
prisma call in the source code. To do so, we use a reg exp, which turned
out to be of exponential complexity. To make matters worth, embedded
DMMF in client prior to 4.0.0 could actually trigger exponential
backgtracking by itself.
Fix #12355