refactor: rename variants of BinaryType enum #18455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqrln
force-pushed
the
refactor/rename-binarytype-variants
branch
from
2b6eaff
to
fc645bb
Compare
|
A couple of places were missing because that code was removed before renaming (those changes were then separated to #18454). |
CodSpeed Performance ReportMerging #18455 Summary
Benchmarks breakdown
|
millsp
approved these changes
Mar 23, 2023
aqrln
force-pushed
the
refactor/rename-binarytype-variants
branch
2 times, most recently
from
fc645bb
to
71cb343
Compare
Rename `queryEngine` to `QueryEngineBinary`, `libqueryEngine` to `QueryEngineLibrary`, and `migrationEngine` to `MigrationEngineBinary`.
aqrln
force-pushed
the
refactor/rename-binarytype-variants
branch
from
71cb343
to
587ffc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
queryEnginetoQueryEngineBinary,libqueryEnginetoQueryEngineLibrary, andmigrationEnginetoMigrationEngineBinary.