Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump benchmark.js codspeed plugin to 1.0.2 #18514

Merged
merged 1 commit into from
Mar 27, 2023
Merged

chore(deps): bump benchmark.js codspeed plugin to 1.0.2 #18514

merged 1 commit into from
Mar 27, 2023

Conversation

art049
Copy link
Contributor

@art049 art049 commented Mar 27, 2023 •
edited

Bump the codspeed benchmark.js plugin to fix a problem related to Deferred benchmarks as discussed with @janpio

@art049 art049 requested a review from a team March 27, 2023 11:09
@art049 art049 requested review from millsp and removed request for a team March 27, 2023 11:09
@CLAassistant
Copy link

CLAassistant commented Mar 27, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 27, 2023 •
edited

CodSpeed Performance Report

Merging #18514 art049:bump-codspeed-benchmark-plugin (273f54b) will degrade performances by 7376.9%.

Summary

🔥 0 improvements
❌ 2 regressions
✅ 0 untouched benchmarks

🆕 1 new benchmarks
⁉️ 0 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main art049:bump-codspeed-benchmark-plugin Change
❌ client generation ~50 Models 46.9 ms 6,843 ms -14486.44%
❌ typescript compilation ~50 Models 12.6 ms 46.5 ms -267.41%
🆕 client generation 100 models with relations N/A 40.3 s N/A

@janpio

This comment was marked as outdated.

Sign in to view
@art049 art049 force-pushed the bump-codspeed-benchmark-plugin branch from ff4eda0 to 29be69c Compare March 27, 2023 16:23
@art049 art049 force-pushed the bump-codspeed-benchmark-plugin branch from 29be69c to 273f54b Compare March 27, 2023 16:32
@janpio janpio added this to the 4.12.0 milestone Mar 27, 2023
@janpio janpio merged commit 4c139e5 into prisma:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jolg42 Jolg42 Awaiting requested review from Jolg42

@jkomyno jkomyno Awaiting requested review from jkomyno

@millsp millsp Awaiting requested review from millsp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@art049 @CLAassistant @janpio