fix(client): Correct result for hasOwn/hasOwnProperty on proxies #18519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem is in compositeProxy implamentation: we always returned a descriptor from `getOwnPropertyDescriptor`, which caused `hasOwnProperty` to always return `true` regardless of propery existence. Fix #18462
CodSpeed Performance ReportMerging #18519 Summary
Benchmarks breakdown
|
millsp
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem is in compositeProxy implamentation: we always returned a
descriptor from
getOwnPropertyDescriptor, which causedhasOwnPropertyto always return
trueregardless of propery existence.Fix #18462