Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated set output #18913

Closed
wants to merge 1 commit into from
Closed

chore: remove deprecated set output #18913

wants to merge 1 commit into from

Conversation

Jolg42
Copy link
Member

@Jolg42 Jolg42 commented Apr 25, 2023

@Jolg42 Jolg42 added this to the 4.14.0 milestone Apr 25, 2023
@Jolg42 Jolg42 requested a review from jkomyno as a code owner April 25, 2023 08:07
@Jolg42 Jolg42 requested review from a team and aqrln and removed request for a team April 25, 2023 08:07
@Jolg42
Copy link
Member Author

Jolg42 commented Apr 25, 2023

It looked like core.setOutput was deprecated (actions/toolkit#1218) but it looks more complicated than that, it has a compatibility mode.
So I'll close it as it works perfectly for us here and I definitely prefer one line

@Jolg42 Jolg42 closed this Apr 25, 2023
@Jolg42 Jolg42 deleted the joel/set-output branch April 25, 2023 08:13
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 25, 2023

CodSpeed Performance Report

Merging #18913 joel/set-output (dc2ff63) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 3 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkomyno jkomyno Awaiting requested review from jkomyno

@aqrln aqrln Awaiting requested review from aqrln

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.14.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Jolg42