Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fetch-engine): remove outdated TODO comment #18978

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Apr 27, 2023

Discussed during a deep dive meeting.

Discussed during a deep dive meeting.
@aqrln aqrln requested review from a team, SevInf and millsp and removed request for a team April 27, 2023 14:41
@Jolg42 Jolg42 merged commit 9fbb3be into main Apr 27, 2023
6 of 55 checks passed
@Jolg42 Jolg42 deleted the cache-remove-todo branch April 27, 2023 14:42
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 27, 2023

CodSpeed Performance Report

Merging #18978 cache-remove-todo (2062e05) will degrade performances by 300.1%.

Summary

🔥 0 improvements
❌ 1 regressions
✅ 2 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main cache-remove-todo Change
typescript compilation ~50 Models 64.3 ms 665.3 ms -934.05%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants