Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Reduce the number of jobs, move some of them to once a day #19001

Merged
merged 8 commits into from
May 5, 2023

Conversation

SevInf
Copy link
Contributor

@SevInf SevInf commented Apr 28, 2023

Following builds will be done once a day after this is merged:

  • all binary engine tests
  • json protocol with non-minimal supported version

If PR contains ci test all comment, all of those things will be
checked. If not, the job that will test them will run at 4am UTC from Monday to Friday.

Since we now need two jobs on different schedules, we need a way to
differentiate them: for that reason, both buildpulse and new nightly
jobs are implemented as separate workflows, that call original one
passing the reason (daily/buildpulse) as a parameter.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 28, 2023

CodSpeed Performance Report

Merging #19001 chore/ci-nightly (d73313f) will degrade performances by 53.0%.

Summary

🔥 0 improvements
❌ 1 regressions
✅ 2 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main chore/ci-nightly Change
typescript compilation ~50 Models 99.2 ms 262 ms -164.24%

@SevInf SevInf added this to the 4.14.0 milestone Apr 28, 2023
@SevInf SevInf force-pushed the chore/ci-nightly branch 3 times, most recently from 1bfbe8d to 32982b9 Compare May 5, 2023 13:19
@SevInf
Copy link
Contributor Author

SevInf commented May 5, 2023

Since new workflows won't be visible until we merge this to main, I'd suggest we do a review now and then test it later.

@SevInf SevInf marked this pull request as ready for review May 5, 2023 13:21
@SevInf SevInf requested review from Jolg42 and jkomyno as code owners May 5, 2023 13:21
@SevInf SevInf requested review from a team and aqrln and removed request for a team May 5, 2023 13:21
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
SevInf added 2 commits May 5, 2023 15:36
Following builds will be done once a day after this is merged:
- all binary engine tests
- json protocol with non-minimal supported version

If PR contains `ci build all` comment, all of those things will be
checked. If not, the job that will test them will run at 9am UTC.

Since we now need two jobs on different schedules, we need a way to
differentiate them: for that reason, both buildpulse and new nightly
jobs are implemented as separate workflows, that call original one
passing the reason (daily/buildpulse) as a parameter.
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@SevInf SevInf requested review from Jolg42 and janpio May 5, 2023 15:15
Copy link
Member

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot ✨

@SevInf SevInf merged commit 686d4d1 into main May 5, 2023
33 of 36 checks passed
@SevInf SevInf deleted the chore/ci-nightly branch May 5, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants