Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change shortlink for bundler-investigation on error case #19247

Merged
merged 2 commits into from
May 15, 2023

Conversation

janpio
Copy link
Member

@janpio janpio commented May 15, 2023

To be able to differentiate between people that just get the warning (the fallback catches them) and the ones that actually crash (no fallback is enough for them, so their app stops working) I created a new shortlink https://pris.ly/bundler-investigation-error (for now points to the same issue, we of course should change that to point to a different one with slightly different questions).

@janpio janpio requested review from Jolg42 and millsp May 15, 2023 08:46
@janpio janpio marked this pull request as ready for review May 15, 2023 08:50
@janpio janpio requested a review from a team May 15, 2023 08:50
@codspeed-hq
Copy link

codspeed-hq bot commented May 15, 2023

CodSpeed Performance Report

Merging #19247 janpio/bundler-investigation-error (d0d3092) will degrade performances by 99.5%.

Summary

🔥 0 improvements
❌ 1 regressions
✅ 3 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main janpio/bundler-investigation-error Change
typescript compilation ~50 Models 98.5 ms 495.6 ms -403.23%

@Jolg42 Jolg42 added this to the 4.15.0 milestone May 15, 2023
@millsp millsp merged commit 028ee57 into main May 15, 2023
68 of 69 checks passed
@millsp millsp deleted the janpio/bundler-investigation-error branch May 15, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants