fix(generator-helper): continuously handle generator errors #19385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle generator process errors during the lifetime of the child process and not just during the first 200 ms. This change completely removes `initWaitTime`, which means that `prisma generate` command will now be faster.
aqrln
commented
May 24, 2023
aqrln
commented
May 24, 2023
aqrln
commented
May 24, 2023
CodSpeed Performance ReportMerging #19385 Congrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
Jolg42
reviewed
May 24, 2023
Jolg42
reviewed
May 24, 2023
Jolg42
reviewed
May 24, 2023
Jolg42
reviewed
May 24, 2023
aqrln
commented
May 25, 2023
millsp
reviewed
May 25, 2023
millsp
approved these changes
May 26, 2023
aqrln
added a commit
that referenced
this pull request
Jun 16, 2023
Unless `wait: true` is passed to `open`, it does not install an `error` event listener to the child process, so it's on us to handle it. Before #19385 all errors that happen in CLI were silenly ignored, so this issue was hidden. This PR fixes it. The added e2e test fails with `Error: spawn xdg-open ENOENT` without the changes in `Studio.ts`, and passes with them. Adding special debug logs that the test depends on was necessary since the error happens asynchronously later, so we can't depend on the "Prisma Studio is up on http://localhost:5555" message, and we need to depend on some output that's printed after the point where the ENOENT error may have happened to determine we can send SIGINT to the child process so that test doesn't hang infinitely. An alternative would've been to rely on a timeout to terminate the process, but that would be unreliable/flaky. Fixes: prisma/studio#1128
aqrln
added a commit
that referenced
this pull request
Jun 16, 2023
…19812) Unless `wait: true` is passed to `open`, it does not install an `error` event listener to the child process, so it's on us to handle it. Before #19385 all errors that happen in CLI were silenly ignored, so this issue was hidden. This PR fixes it. The added e2e test fails with `Error: spawn xdg-open ENOENT` without the changes in `Studio.ts`, and passes with them. Adding special debug logs that the test depends on was necessary since the error happens asynchronously later, so we can't depend on the "Prisma Studio is up on http://localhost:5555" message, and we need to depend on some output that's printed after the point where the ENOENT error may have happened to determine we can send SIGINT to the child process so that test doesn't hang infinitely. An alternative would've been to rely on a timeout to terminate the process, but that would be unreliable/flaky. Fixes: prisma/studio#1128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initWaitTime, handle errors properly all the timewrite EPIPEerror when the generator stopped but the CLI still tries to send messagesFixes #3294
Fixes #8314
Fixes #10291
Fixes #14002