Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): types for mixed input type selections #20180

Merged
merged 7 commits into from
Jul 26, 2023
Merged

fix(client): types for mixed input type selections #20180

merged 7 commits into from
Jul 26, 2023

Conversation

millsp
Copy link
Member

@millsp millsp commented Jul 12, 2023 •
edited

closes #20093
closes #19962

@millsp millsp added this to the 5.1.0 milestone Jul 12, 2023
@millsp millsp marked this pull request as ready for review July 20, 2023 21:45
@millsp millsp requested a review from a team as a code owner July 20, 2023 21:45
@millsp millsp requested review from SevInf and Druue and removed request for a team July 20, 2023 21:45
@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: typescript@4.4.4, typescript@4.5.5, typescript@4.6.4

jkomyno
jkomyno approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@jkomyno jkomyno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a couple of questions

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 21, 2023

CodSpeed Performance Report

Merging #20180 will degrade performances by 10.71%

Comparing integration/fix/client/types-mixed-input-types (d80ee55) with main (8bcd1ee)

Summary

❌ 1 regressions
✅ 3 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main integration/fix/client/types-mixed-input-types Change
❌ typescript compilation ~50 Models 56.6 ms 63.4 ms -10.71%

@Jolg42 Jolg42 requested review from aqrln and removed request for Druue July 21, 2023 08:50
@millsp millsp mentioned this pull request Jul 25, 2023
Merged
@millsp millsp merged commit 204bd63 into main Jul 26, 2023
65 of 68 checks passed
@millsp millsp deleted the integration/fix/client/types-mixed-input-types branch July 26, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevInf SevInf SevInf approved these changes

@jkomyno jkomyno jkomyno approved these changes

@aqrln aqrln Awaiting requested review from aqrln

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.0
3 participants
@millsp @SevInf @jkomyno