Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): nullability for *OrThrow methods via fluent API #20197

Merged
merged 6 commits into from
Jul 18, 2023
Merged

fix(client): nullability for *OrThrow methods via fluent API #20197

merged 6 commits into from
Jul 18, 2023

Conversation

millsp
Copy link
Member

@millsp millsp commented Jul 12, 2023 •
edited

closes #20183

@millsp millsp added this to the 5.1.0 milestone Jul 12, 2023
@millsp millsp marked this pull request as ready for review July 12, 2023 19:30
@millsp millsp requested a review from a team as a code owner July 12, 2023 19:30
@millsp millsp requested review from Jolg42, Druue and SevInf and removed request for a team July 12, 2023 19:30
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 12, 2023

CodSpeed Performance Report

Merging #20197 will degrade performances by 51.54%

Comparing fix(client)--nullability-for--OrThrow-methods-via-fluent-API (6af2582) with main (99a96e8)

Summary

❌ 1 regressions
✅ 3 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix(client)--nullability-for--OrThrow-methods-via-fluent-API Change
❌ typescript compilation ~50 Models 77.4 ms 159.7 ms -51.54%

@Jolg42 Jolg42 requested review from aqrln and removed request for Druue July 18, 2023 08:19
@millsp millsp merged commit a83f166 into main Jul 18, 2023
62 of 63 checks passed
@millsp millsp deleted the fix(client)--nullability-for--OrThrow-methods-via-fluent-API branch July 18, 2023 23:32
@Jolg42 Jolg42 mentioned this pull request Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevInf SevInf SevInf approved these changes

@Jolg42 Jolg42 Awaiting requested review from Jolg42 Jolg42 was automatically assigned from prisma/orm-ts-maintain

@aqrln aqrln Awaiting requested review from aqrln

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.

Wrong nullable types with fluent API in Prisma 5.0
2 participants
@millsp @SevInf