Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): Fix $Enums namespace in browser build #20481

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Conversation

SevInf
Copy link
Contributor

@SevInf SevInf commented Aug 1, 2023

$Enums namespace was correctly created for server-side clients, but not
for browser.

Fix #20480

/integration

$Enums namespace was correctly created for server-side clients, but not
for browser.

Fix #20480
@SevInf SevInf requested a review from a team as a code owner August 1, 2023 15:25
@SevInf SevInf requested review from Jolg42 and aqrln and removed request for a team August 1, 2023 15:25
@SevInf SevInf added this to the 5.2.0 milestone Aug 1, 2023
Copy link
Member

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@SevInf SevInf merged commit 57d3fbe into main Aug 2, 2023
62 checks passed
@SevInf SevInf deleted the fix/enums-browser branch August 2, 2023 07:36
SevInf added a commit that referenced this pull request Aug 2, 2023
* fix(client): Fix $Enums namespace in browser build

$Enums namespace was correctly created for server-side clients, but not
for browser.

Fix #20480

* Snapshots & readme

* Proper test name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser bundle: Unhandled Runtime Error when upgrading to 5.1.0 from 5.0.0
4 participants