Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(adapter-planetscale): Map CHAR columns to text column types #21706

Merged
merged 1 commit into from
Nov 1, 2023
Merged

fix(adapter-planetscale): Map CHAR columns to text column types #21706

merged 1 commit into from
Nov 1, 2023

Conversation

SevInf
Copy link
Contributor

@SevInf SevInf commented Oct 31, 2023

CHAR db type does not mean single character. It should be mapped to
Text type instead.

Fix #21592

@SevInf
fix(adapter-planetscal): Map CHAR columns to text column types
fafc93a 
`CHAR` db type does not mean single character. It should be mapped to
Text type instead.

Fix #21592
@SevInf SevInf requested a review from a team as a code owner October 31, 2023 17:17
@SevInf SevInf requested review from Jolg42 and aqrln and removed request for a team October 31, 2023 17:17
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023 •
edited

size-limit report 📦

Path Size
packages/client/runtime/library.d.ts 99.02 KB (0%)
packages/client/runtime/library.js 182.25 KB (0%)
packages/client/runtime/binary.js 600.04 KB (0%)
packages/client/runtime/edge.js 209.7 KB (0%)
packages/cli/build/index.js 5.18 MB (0%)

@SevInf SevInf changed the title fix(adapter-planetscal): Map CHAR columns to text column types fix(adapter-planetscale): Map CHAR columns to text column types Oct 31, 2023
jkomyno
jkomyno approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@jkomyno jkomyno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to remove ColumnTypeEnum.Char (and the equivalent one in prisma-engines) as well?

@Jolg42 Jolg42 added this to the 5.6.0 milestone Oct 31, 2023
@SevInf
Copy link
Contributor Author

SevInf commented Oct 31, 2023

@jkomyno, removed JS CHAR in this PR, will send follow up to rust side later.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 31, 2023 •
edited

CodSpeed Performance Report

Merging #21706 will not alter performance

Comparing fix/char-planetscale (fafc93a) with main (ef2a5c6)

Summary

✅ 3 untouched benchmarks

@aqrln
Copy link
Member

aqrln commented Oct 31, 2023

@jkomyno Char type exists in quaint, so maybe not.

@SevInf SevInf merged commit 64bd95d into main Nov 1, 2023
179 of 183 checks passed
@SevInf SevInf deleted the fix/char-planetscale branch November 1, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkomyno jkomyno jkomyno approved these changes

@millsp millsp millsp approved these changes

@Jolg42 Jolg42 Awaiting requested review from Jolg42 Jolg42 was automatically assigned from prisma/orm-ts-maintain

@aqrln aqrln Awaiting requested review from aqrln aqrln was automatically assigned from prisma/orm-ts-maintain

Assignees

@SevInf SevInf

Labels
None yet
Projects
None yet
Milestone
5.6.0
Development

Successfully merging this pull request may close these issues.

Update and read issues with @prisma/adapter-planetscale
5 participants
@SevInf @aqrln @jkomyno @millsp @Jolg42