Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client/createManyAndReturn): fix TS input types #24099

Merged
merged 5 commits into from May 8, 2024

Conversation

Jolg42
Copy link
Member

@Jolg42 Jolg42 commented May 7, 2024

@Jolg42 Jolg42 added this to the 5.14.0 milestone May 7, 2024
Copy link
Contributor

github-actions bot commented May 7, 2024

size-limit report 📦

Path Size
packages/client/runtime/library.js 179.77 KB (0%)
packages/client/runtime/library.d.ts 81 B (0%)
packages/client/runtime/binary.js 600.89 KB (0%)
packages/client/runtime/binary.d.ts 26 B (0%)
packages/client/runtime/edge.js 159.02 KB (0%)
packages/client/runtime/edge-esm.js 158.91 KB (0%)
packages/client/runtime/wasm.js 114.85 KB (0%)
packages/client/runtime/index-browser.js 33.77 KB (0%)
packages/client/runtime/index-browser.d.ts 89 B (0%)
packages/cli/build/index.js 2.09 MB (0%)
packages/client/prisma-client-0.0.0.tgz 3.02 MB (+0.01% 🔺)
packages/cli/prisma-0.0.0.tgz 3.74 MB (+0.01% 🔺)
packages/bundle-size/da-workers-libsql/output.tgz 888.14 KB (0%)
packages/bundle-size/da-workers-neon/output.tgz 966.74 KB (0%)
packages/bundle-size/da-workers-pg/output.tgz 985.47 KB (0%)
packages/bundle-size/da-workers-pg-worker/output.tgz 941.18 KB (0%)
packages/bundle-size/da-workers-planetscale/output.tgz 903.56 KB (0%)
packages/bundle-size/da-workers-d1/output.tgz 861.2 KB (0%)

@Jolg42 Jolg42 marked this pull request as ready for review May 7, 2024 16:36
@Jolg42 Jolg42 requested a review from a team as a code owner May 7, 2024 16:36
@Jolg42 Jolg42 requested review from Druue, SevInf and a team and removed request for a team May 7, 2024 16:36
Copy link

codspeed-hq bot commented May 8, 2024

CodSpeed Performance Report

Merging #24099 will degrade performances by 21.96%

Comparing joel/fix-createManyAndReturn-types (bfbc8ab) with main (dd0221e)

Summary

❌ 1 regressions
✅ 2 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main joel/fix-createManyAndReturn-types Change
client generation 100 models with relations 29.7 s 38 s -21.96%

@Jolg42 Jolg42 merged commit 2ddab85 into main May 8, 2024
203 of 204 checks passed
@Jolg42 Jolg42 deleted the joel/fix-createManyAndReturn-types branch May 8, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants