-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(adapter-d1): set maxBindValues: 100 #24242
feat(adapter-d1): set maxBindValues: 100 #24242
Conversation
size-limit report 📦
|
CodSpeed Performance ReportMerging #24242 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have some test(s) for this now? (For D1 and other adapters)
Not that I could find, except the prisma-engines one, |
https://github.com/prisma/prisma-engines/blob/main/query-engine/connector-test-kit-rs/query-engine-tests/tests/new/regressions/prisma_7434.rs excludes D1 from what I see, so this fix for D1 is untested. Could you add a test somewhere? in functional tests would be nice maybe? |
I remember that I actually some tests in this PR, I guess that's enough? Could you check @jkomyno ? |
…52413cd0' into integration/fix-sqlite-d1-max-bind-values
6359463
into
deps/engines-5.15.0-26.9599c67575e2ecde6e2aa528c1f8e28752413cd0
This PR contributes to https://github.com/prisma/team-orm/issues/1070.
Please merge after prisma/prisma-engines#4878 is released.
This should fix the issues mentioned in https://github.com/prisma/team-orm/issues/1070#issuecomment-2079497069 as well (TODO: check after this is merged and well-integrated).