chore: Upgrade ESLint to v9

[nzakas]

This is an attempt to upgrade the repo to ESLint v9.

I've verified that the new config file works and ESLint runs. However, there are some outstanding ESLint errors that need review from someone familiar with the codebase. I believe these are valid, but they didn't show up before the migration, so it's possible you may want to ignore them.

C:\Users\nzaka\projects\third-party\prisma\helpers\blaze\omit.ts      
  11:45  error  Unexpected constant truthiness on the left-hand side of a `&&` expression  no-constant-binary-expression
  17:45  error  Unexpected constant truthiness on the left-hand side of a `&&` expression  no-constant-binary-expression

C:\Users\nzaka\projects\third-party\prisma\helpers\blaze\pick.ts      
  11:45  error  Unexpected constant truthiness on the left-hand side of a `&&` expression  no-constant-binary-expression
  17:45  error  Unexpected constant truthiness on the left-hand side of a `&&` expression  no-constant-binary-expression

C:\Users\nzaka\projects\third-party\prisma\packages\nextjs-monorepo-workaround-plugin\index.js
  121:57  error  'from' is defined 
but never used. Allowed unused args must match /^_/u  @typescript-eslint/no-unused-vars

[CLAassistant]

All committers have signed the CLA.

[socket-security]

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

[Jolg42]

Oh! That's interesting, because I identified this as a blocker recently and this unblocks it.

(In #24148 (review))

[Jolg42]

Thanks a lot @nzakas! 🙌🏼

I think we can ignore these errors for the blaze utils and rename from to _from for nextjs-monorepo-workaround-plugin.

Could you do that? I could not push a commit because of a permission error.

Also, we would need to have the CLA signed to be able to merge the PR later. Could you check this in the message above?

Ping @millsp for info and for the blaze utils where we need to ignore the eslint errors.

[millsp]

Thanks @nzakas for taking the time, this is very much appreciated.

@Jolg42 @nzakas these eslint errors should be ignored as it is intentional in the implementation.

C:\Users\nzaka\projects\third-party\prisma\helpers\blaze\omit.ts      
  11:45  error  Unexpected constant truthiness on the left-hand side of a `&&` expression  no-constant-binary-expression
  17:45  error  Unexpected constant truthiness on the left-hand side of a `&&` expression  no-constant-binary-expression

C:\Users\nzaka\projects\third-party\prisma\helpers\blaze\pick.ts      
  11:45  error  Unexpected constant truthiness on the left-hand side of a `&&` expression  no-constant-binary-expression
  17:45  error  Unexpected constant truthiness on the left-hand side of a `&&` expression  no-constant-binary-expression

and the variable producing an error here can be prefixed with an underscore to suppress the error.

C:\Users\nzaka\projects\third-party\prisma\packages\nextjs-monorepo-workaround-plugin\index.js
  121:57  error  'from' is defined 
but never used. Allowed unused args must match /^_/u  @typescript-eslint/no-unused-vars

[nzakas]

CLA signed.

Updated the config file to ignore the blaze directory and renamed from to _from.

[gutyerrez]

I see only one problem in this part. eslintrc will be long not supported and not maintened again. The compat "transforms" the configuration to support eslintrc old configuration. In this case i really want the best thing is to adapt fully to new eslint format.

[nzakas]

That's a good approach in the long run. For right now, there are still too many plugins that don't officially support the new config format, so we need this. You can always revisit later as plugins are updated.

[gutyerrez]

TypeScript eslint now support Eslint v9. Here's a explain typescript-eslint/typescript-eslint#8211 (comment)

Prettier too have a Eslint v9 support. Here's a merged PR prettier/eslint-plugin-prettier#616

And you can see all supported parsers/plugins in the issue 18391

[nzakas]

Yes, I maintain ESLint, so I'm aware. :)

This is just meant to be a courtesy PR to help get you started. This was generated by our new migration tool so there are some inefficiencies, but you can modify this however you'd like.

[gutyerrez]

Nice! Now i understand everything, thanks for the explain

[gutyerrez]

With the v9 release eslint give's a way to define rules for specific file extensions. in this block you have only a file extensions without inserting rules and others things. Are that really working good?

[nzakas]

Yes. This is telling ESLint to search for **/*.ts files by default. This replaces the --ext .ts command line flag. You can optionally include additional configuration if you want, but the primary focus of this entry is to ensure that TypeScript files are search for by default.

[Jolg42]

Thanks a lot 🙌🏼