-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): generate
, add --no-hint
argument
#24274
Conversation
generate
, add --no-hint
argument
@gutyerrez I've addressed your comments and the CI tests are now passing. It seems like someone has to add a milestone before the last check will pass but other than that it should be good to go :) |
CodSpeed Performance ReportMerging #24274 will not alter performanceComparing Summary
|
@Jolg42 I see that you removed the milestone. Is there something I need to do to get this added back? |
@SevInf is there anything more I need to do to get this merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nickcarnival!
Thank you for submitting the PR. I've left a few comments, after my feedback is addressed this should be good to merge.
@SevInf thanks so much for the review, I believe I've addressed all of your comments. |
Thank you, waiting for final CI run and merging |
Thanks for fixing those last few items. |
This PR aims to remove some of the bloat that's output everytime you run
prisma generate
by adding a--no-hint
flag to thegenerate
command:Closes #22513
I've also created a sister PR in the
withfig/autocomplete
repo: withfig/autocomplete#2345