Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): generate, add --no-hint argument #24274

Merged
merged 10 commits into from
Jun 10, 2024
Merged

Conversation

nickcarnival
Copy link
Contributor

@nickcarnival nickcarnival commented May 23, 2024

This PR aims to remove some of the bloat that's output everytime you run prisma generate by adding a --no-hint flag to the generate command:

Closes #22513

prisma generate --no-hint

Screenshot 2024-05-23 at 12 50 34 PM

prisma generate

Screenshot 2024-05-23 at 12 50 04 PM

I've also created a sister PR in the withfig/autocomplete repo: withfig/autocomplete#2345

@nickcarnival nickcarnival requested a review from a team as a code owner May 23, 2024 18:52
@nickcarnival nickcarnival requested review from Druue and removed request for a team May 23, 2024 18:52
@CLAassistant
Copy link

CLAassistant commented May 23, 2024

CLA assistant check
All committers have signed the CLA.

packages/cli/src/Generate.ts Outdated Show resolved Hide resolved
packages/cli/src/Generate.ts Outdated Show resolved Hide resolved
@janpio janpio changed the title feat(cli): generate add --no-hint argument Closes #22513 feat(cli): generate add --no-hint argument May 23, 2024
@janpio janpio changed the title feat(cli): generate add --no-hint argument feat(cli): generate, add --no-hint argument May 24, 2024
@nickcarnival
Copy link
Contributor Author

@gutyerrez I've addressed your comments and the CI tests are now passing. It seems like someone has to add a milestone before the last check will pass but other than that it should be good to go :)

Copy link

codspeed-hq bot commented May 29, 2024

CodSpeed Performance Report

Merging #24274 will not alter performance

Comparing nickcarnival:main (33cccc8) with main (317dd04)

Summary

✅ 3 untouched benchmarks

@nickcarnival
Copy link
Contributor Author

@Jolg42 I see that you removed the milestone. Is there something I need to do to get this added back?
It seems like that's the only check left for this PR.

packages/cli/src/platform/auth/login.ts Outdated Show resolved Hide resolved
packages/client/tests/functional/omit/test.ts Outdated Show resolved Hide resolved
packages/get-platform/src/test-utils/index.ts Outdated Show resolved Hide resolved
@nickcarnival
Copy link
Contributor Author

@SevInf is there anything more I need to do to get this merged?

@SevInf SevInf requested review from SevInf and removed request for Druue and gutyerrez June 7, 2024 08:46
Copy link
Member

@SevInf SevInf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nickcarnival!
Thank you for submitting the PR. I've left a few comments, after my feedback is addressed this should be good to merge.

packages/cli/src/Generate.ts Outdated Show resolved Hide resolved
packages/cli/src/Generate.ts Outdated Show resolved Hide resolved
packages/cli/src/__tests__/commands/Generate.test.ts Outdated Show resolved Hide resolved
@SevInf SevInf added this to the 5.16.0 milestone Jun 7, 2024
@nickcarnival
Copy link
Contributor Author

@SevInf thanks so much for the review, I believe I've addressed all of your comments.

@nickcarnival nickcarnival requested a review from SevInf June 7, 2024 15:35
@SevInf
Copy link
Member

SevInf commented Jun 10, 2024

Thank you, waiting for final CI run and merging

@nickcarnival
Copy link
Contributor Author

Thank you, waiting for final CI run and merging

Thanks for fixing those last few items.

@SevInf SevInf merged commit a59dc6f into prisma:main Jun 10, 2024
214 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable "Start using Prisma Client" hint logs on prisma generate
5 participants