Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiment: avoid double deserialization + deserialize arrays #24583

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Weakky
Copy link
Member

@Weakky Weakky commented Jun 19, 2024

Do not merge

Implements deserialization of queryRaw results serialized as arrays instead of objects.

QE related PR: prisma/prisma-engines#4928

Copy link
Contributor

size-limit report 📦

Path Size
packages/client/runtime/library.js 371.02 KB (+105.83% 🔺)
packages/client/runtime/library.d.ts 81 B (0%)
packages/client/runtime/binary.js 1.12 MB (+90.61% 🔺)
packages/client/runtime/binary.d.ts 26 B (0%)
packages/client/runtime/edge.js 324.32 KB (+103.47% 🔺)
packages/client/runtime/edge-esm.js 323.62 KB (+103.17% 🔺)
packages/client/runtime/wasm.js 255.83 KB (+121.92% 🔺)
packages/client/runtime/index-browser.js 66.39 KB (+95.86% 🔺)
packages/client/runtime/index-browser.d.ts 89 B (0%)
packages/cli/build/index.js 2.1 MB (0%)
packages/client/prisma-client-0.0.0.tgz 3.05 MB (+6.32% 🔺)
packages/cli/prisma-0.0.0.tgz 3.83 MB (+4.49% 🔺)
packages/bundle-size/da-workers-libsql/output.tgz 874.31 KB (+1.75% 🔺)
packages/bundle-size/da-workers-neon/output.tgz 950.72 KB (+1.57% 🔺)
packages/bundle-size/da-workers-pg/output.tgz 970.19 KB (+1.64% 🔺)
packages/bundle-size/da-workers-pg-worker/output.tgz 924.81 KB (+1.6% 🔺)
packages/bundle-size/da-workers-planetscale/output.tgz 886.82 KB (+1.71% 🔺)
packages/bundle-size/da-workers-d1/output.tgz 846.49 KB (+1.8% 🔺)

Copy link

codspeed-hq bot commented Jun 19, 2024

CodSpeed Performance Report

Merging #24583 will degrade performances by 23.45%

Comparing perf/query-raw-experiment (b7f168d) with main (3472a7e)

Summary

❌ 1 regressions
✅ 2 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main perf/query-raw-experiment Change
client generation 100 models with relations 6.1 s 7.9 s -23.45%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant