Uds support #3259
Uds support #3259
Conversation
timsuchanek
force-pushed
the
uds-support
branch
from
d14c78f
to
7c98bda
Compare
| @@ -166,6 +172,12 @@ export class NodeEngine { | |||
| ) | |||
| this.engineEndpoint = engineEndpoint | |||
|
|
|||
| if (useUds && process.platform !== 'win32') { | |||
| this.socketPath = `/tmp/prisma-${getRandomString()}.sock` | |||
There was a problem hiding this comment.
What are the chances that the filesystem refuse access to /tmp/ or if it's read only? I guess the socket would not initialize?
Should we check that first maybe like this?
try {
// R_OK | Flag indicating that the file can be read by the calling process.
// W_OK | Flag indicating that the file can be written by the calling process.
fs.accessSync(path.dirname(this.socketPath), fs.constants.R_OK | fs.constants.W_OK)
}
catch (err) {
// err
}There was a problem hiding this comment.
I'm not aware of any case, in which /tmp is not writable.
I would personally keep it simple for now.
| if (!this.useUds) { | ||
| env.PORT = String(this.port) | ||
| } else { | ||
| debug(`port: ${this.port}`) |
There was a problem hiding this comment.
Why is the debug only for useUds is truthy?
There was a problem hiding this comment.
Oops that's wrong, will fix
|
Also it looks like test failed in CI |
Yep, that's why I'm setting up a Linux machine right now, because I can't reproduce the failing tests on Mac. |
timsuchanek
force-pushed
the
uds-support
branch
from
3b14312
to
bf9a100
Compare
|
UDS can be enabled with new PrismaClient({ __internal: { useUds: true } }) |
|
I tried it out and looks like it is working well 💯
|
Closes #3092