fix(cli): Ignore all errors that occur when opening Studio in a browser #4119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdnts
commented
Nov 2, 2020
| app: browser, | ||
| url: true, | ||
| // eslint-disable-next-line @typescript-eslint/no-empty-function | ||
| }).catch(() => { }) // Ignore any errors |
There was a problem hiding this comment.
This is not going to ignore errors like I expect
Jolg42
added a commit
that referenced
this pull request
Nov 4, 2020
* master: (25 commits) chore: cleanup tests chore: update snapshots fix: only generate .env path if present fix: improve warning fix(client): stack trace with source-map-support. Closes #3945 (#4137) feat(client, sdk, cli): env loading rewrite (#4142) ci: increase health check retries for db GH Actions fix(deps): update dependency undici to v2.1.1 (#4135) chore(deps): update devdependencies (non-major) fix(deps): update engines to v2.11.1-4-1d5919363a85847350c3f517da9babd9bcaca792 (#4131) ci: try fix for flaky client GH actions chore(deps): update studio to v0.307.0 (#4128) fix(client): remove package.json in custom output paths (#4130) feat: stabilize transaction & connectOrCreate (#4129) fix: print getConfig warnings (#4124) fix(cli): Ignore all errors that occur when opening Studio in a browser (#4119) chore: update renovate for Studio [skip ci] Bump Studio [skip ci] chore(cli): preinstall throw on node < 10 (#4118) chore: cleanup jest config (#4120) ... # Conflicts: # src/packages/migrate/src/bin.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes prisma/studio#563