fix: group by #4768
Merged
fix: group by #4768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jolg42
reviewed
Dec 28, 2020
...packages/client/src/__tests__/integration/happy/exhaustive-schema/__snapshots__/test.ts.snap
Show resolved
Hide resolved
Jolg42
reviewed
Dec 28, 2020
Comment on lines
+64
to
+77
| body: (ctx) => `Group by ${ctx.singular}. | ||
| @param {${getGroupByArgsName(ctx.model.name)}} args - Group by arguments. | ||
| @example | ||
| // Group by city, order by createdAt, get count | ||
| const result = await prisma.user.groupBy({ | ||
| by: ['city', 'createdAt'], | ||
| orderBy: { | ||
| createdAt: true | ||
| }, | ||
| count: { | ||
| _all: true | ||
| }, | ||
| }) | ||
| `, |
There was a problem hiding this comment.
This looks hardcoded @timsuchanek should be dynamic no?
There was a problem hiding this comment.
I intentionally did a hardcoded example here, as it's otherwise quite hard to auto generate the jsdocs (we need to find the right fields, check if they're even there etc).
So I chose an example that always makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type constraints for the following cases:
takeorskipis provided,orderByis requiredorderByneeds to be inbyIntroduces
tsdto write type error tests.