Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass env to Node-API and remove patchJest #7581

Merged
merged 14 commits into from Jun 11, 2021
Merged

fix: pass env to Node-API and remove patchJest #7581

merged 14 commits into from Jun 11, 2021

Conversation

williamluke4
Copy link
Contributor

@williamluke4 williamluke4 commented Jun 10, 2021 •
edited

@williamluke4 williamluke4 changed the title fix: pass env to Node-API fix: pass env to Node-API and remove patchJest Jun 10, 2021
@williamluke4 williamluke4 added this to the 2.25.0 milestone Jun 10, 2021
@Jolg42 Jolg42 mentioned this pull request Jun 10, 2021
Merged
@williamluke4 williamluke4 marked this pull request as ready for review June 10, 2021 13:48
@Jolg42 Jolg42 mentioned this pull request Jun 10, 2021
Merged
1 task
@janpio janpio mentioned this pull request Jun 10, 2021
Closed
7 tasks
Jolg42
Jolg42 approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See --forceExit --clearCache question before we merge

@williamluke4 williamluke4 force-pushed the integration/node-api/virtual-env branch from 41b6077 to a4957e4 Compare June 11, 2021 11:04
@williamluke4 williamluke4 added the topic: node-api formerly `nApi` label Jun 11, 2021
@williamluke4 williamluke4 merged commit f284cc5 into master Jun 11, 2021
@williamluke4 williamluke4 deleted the integration/node-api/virtual-env branch June 11, 2021 11:26
@janpio
Copy link
Member

janpio commented Jun 11, 2021

🥳

Andrew-Colman pushed a commit to Andrew-Colman/prisma that referenced this pull request Aug 7, 2021
@williamluke4 @Andrew-Colman
fix: pass env to Node-API and remove patchJest (prisma#7581)
7ffab2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jolg42 Jolg42 Jolg42 approved these changes

@millsp millsp Awaiting requested review from millsp

Assignees
No one assigned
Labels
topic: node-api formerly `nApi`
Projects
None yet
Milestone
2.25.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@williamluke4 @janpio @Jolg42