Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): pnpm installation #7942

Merged
merged 9 commits into from
Jul 8, 2021
Merged

fix(sdk): pnpm installation #7942

merged 9 commits into from
Jul 8, 2021

Conversation

millsp
Copy link
Member

@millsp millsp commented Jun 30, 2021

Fixes #7934
Fixes #7484

Additionally, I added the necessary tests to E2E.

E2E https://github.com/prisma/e2e-tests/actions/runs/984959475

@matthewmueller
Copy link
Contributor

matthewmueller commented Jun 30, 2021

This might be able to close this issue: #5340

What's left to do in this PR? The task in prisma/ecosystem-tests#1864? Who should review this code?

@millsp millsp marked this pull request as ready for review June 30, 2021 14:11
@millsp
Copy link
Member Author

millsp commented Jun 30, 2021

We are just getting things ready in E2E then we are good to go.

Copy link
Contributor

@williamluke4 williamluke4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 🎉

@Jolg42
Copy link
Member

Jolg42 commented Jul 6, 2021

@millsp I think we should merge this now, could you fix the conflict?

@Jolg42 Jolg42 enabled auto-merge (squash) July 8, 2021 12:34
@Jolg42
Copy link
Member

Jolg42 commented Jul 8, 2021

Seems still conflicting 🤔

Copy link
Member

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Jolg42 Jolg42 merged commit 6e05fcc into master Jul 8, 2021
@Jolg42 Jolg42 deleted the integration/fix-sdk-pnpm branch July 8, 2021 16:44
Andrew-Colman pushed a commit to Andrew-Colman/prisma that referenced this pull request Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.26.0 and pnpm do not play well together Entity types cannot be resolved in PNPM monorepo
4 participants