-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): pnpm installation #7942
Conversation
This might be able to close this issue: #5340 What's left to do in this PR? The task in prisma/ecosystem-tests#1864? Who should review this code? |
We are just getting things ready in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work 🎉
@millsp I think we should merge this now, could you fix the conflict? |
Seems still conflicting 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Fixes #7934
Fixes #7484
Additionally, I added the necessary tests to E2E.
E2E https://github.com/prisma/e2e-tests/actions/runs/984959475