New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: engine type implementation (will replace node api preview feature) #8437

Merged

williamluke4 merged 36 commits into main from integration/enabling-node-api

Aug 11, 2021

Contributor

williamluke4 commented Jul 26, 2021 •

edited

Both the CLI and Client are still by default using the binary but this allows for the change over to be much easier.

Escape Hatches

Client

ENV OVERRIDE

PRISMA_CLIENT_ENGINE_TYPE="library" | "binary"

Schema

generator client {
	provider    = "prisma-client-js"
	engineType  = "binary" | "library" 
}

CLI

ENV OVERRIDE

PRISMA_CLI_QUERY_ENGINE_TYPE="binary" | "library"

williamluke4 commented

View reviewed changes

src/packages/client/src/generation/generateClient.ts Outdated Show resolved Hide resolved

janpio reviewed

View reviewed changes

src/packages/client/src/generation/generateClient.ts Outdated Show resolved Hide resolved

williamluke4 force-pushed the integration/enabling-node-api branch 6 times, most recently from 1ac21c1 to a46af61 Compare

August 2, 2021 16:12

williamluke4 force-pushed the integration/enabling-node-api branch 2 times, most recently from f76c172 to f8e9d93 Compare

August 5, 2021 08:49

Jolg42 reviewed

View reviewed changes

packages/cli/src/Version.ts Outdated Show resolved Hide resolved

Jolg42 reviewed

View reviewed changes

packages/client/src/__tests__/integration/happy/chmod/test.ts Outdated Show resolved Hide resolved

Jolg42 reviewed

View reviewed changes

packages/client/src/__tests__/integration/happy/client-engine/test.ts Outdated Show resolved Hide resolved

Jolg42 reviewed

View reviewed changes

packages/client/src/__tests__/integration/happy/client-engine/test.ts Show resolved Hide resolved

Jolg42 reviewed

View reviewed changes

packages/client/src/runtime/utils/getClientEngineType.ts Outdated Show resolved Hide resolved

Jolg42 reviewed

View reviewed changes

packages/client/src/runtime/utils/getClientEngineType.ts Outdated Show resolved Hide resolved

Jolg42 reviewed

View reviewed changes

packages/client/src/utils/ensureTestClientQueryEngine.ts Outdated Show resolved Hide resolved

Jolg42 reviewed

View reviewed changes

scripts/ci/publish.ts Outdated Show resolved Hide resolved

Jolg42 approved these changes

View reviewed changes

Member

Jolg42 left a comment •

edited by williamluke4

Looks good (see comments)

Question: Is this validated by VSCode / engine validation?
engineType = "binary" | "library"

janpio changed the title ~~feat(client): enable node-api by default~~ feat: engine type implementation (replaces node api preview feature)

janpio changed the title ~~feat: engine type implementation (replaces node api preview feature)~~ feat: engine type implementation (will replace node api preview feature)

janpio reviewed

View reviewed changes

.buildkite/test/run.sh Outdated Show resolved Hide resolved

janpio reviewed

View reviewed changes

.buildkite/test/run.sh Show resolved Hide resolved

janpio reviewed

View reviewed changes

packages/client/fixtures/blog/prisma/schema.prisma Show resolved Hide resolved

janpio reviewed

View reviewed changes

packages/client/src/__tests__/generation/generator.test.ts Outdated Show resolved Hide resolved

millsp reviewed

View reviewed changes

packages/client/src/utils/ensureTestClientQueryEngine.ts Outdated Show resolved Hide resolved

millsp reviewed

View reviewed changes

scripts/ci/publish.ts Show resolved Hide resolved

millsp reviewed

View reviewed changes

packages/client/src/generation/utils.ts Show resolved Hide resolved

millsp reviewed

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

williamluke4 force-pushed the integration/enabling-node-api branch from ccd9cb1 to a7654c0 Compare

August 9, 2021 09:39

williamluke4 and others added 25 commits

August 11, 2021 12:13


          test tmp fix

e32b0f7


          shake

76a797b


          fix remaining tests

12d2693


          change relavant tests to use PRISMA_CLIENT_ENGINE_TYPE

7842e8f


          fix getGenerators test

f16278c


          remove proxy

bb9697c


          update build-kite configuration

419fb9b


          tmp(build-kite): do not use job 2

fa5eae6


          ensureTestClientQueryEngine

c716eb1


          update package-lock

701ccf4


          bump engines

7712a67


          bump-engines

4538a1f


          switch the default client engine to binary and fix rebase issues

6b311fe


          update build kite scripts

a77cd7b


          re-add support for the previewFeature

dddb1ba


          remove nApi from the list of deprecated feature flags

44a4553


          Update NodeAPILibraryTypes.ts

dac39e5


          bump-engines

90fc689


          switch node-api to library

d33ad24


          add  (Binary) to version output

66b1ce6


          node-api to library

933a27a


          implement requested changes

a42ed73


          change buildkite paraparallelism to 2

d611f08


          use rmdirSync

80b990b


          remove rmdirSync

67b0d11

williamluke4 force-pushed the integration/enabling-node-api branch from a7654c0 to 67b0d11 Compare

August 11, 2021 09:15


          bump-engines

b8b1e47

williamluke4 mentioned this pull request

chore(deps): update engines to 2.30.0-1.1be4cd60b89afa04b192acb1ef47758a39810f3a #8684

Closed

williamluke4 merged commit fc7b272 into main

williamluke4 deleted the integration/enabling-node-api branch

August 11, 2021 09:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment