chore: remove encrypt=DANGER_PLAINTEXT #8737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janpio
reviewed
Aug 13, 2021
| - TEST_MSSQL_JDBC_URI=sqlserver://mssql:1433;database=master;user=SA;password=Pr1sm4_Pr1sm4;trustServerCertificate=true;encrypt=DANGER_PLAINTEXT | ||
| - TEST_MSSQL_JDBC_URI_MIGRATE=sqlserver://mssql:1433;database=tests-migrate;user=SA;password=Pr1sm4_Pr1sm4;trustServerCertificate=true;encrypt=DANGER_PLAINTEXT | ||
| - TEST_MSSQL_SHADOWDB_JDBC_URI_MIGRATE=sqlserver://mssql:1433;database=tests-migrate-shadowdb;user=SA;password=Pr1sm4_Pr1sm4;trustServerCertificate=true;encrypt=DANGER_PLAINTEXT | ||
| - TEST_MSSQL_JDBC_URI=sqlserver://mssql:1433;database=master;user=SA;password=Pr1sm4_Pr1sm4;trustServerCertificate=true; |
There was a problem hiding this comment.
Should it maybe be this way instead?
Suggested change
| - TEST_MSSQL_JDBC_URI=sqlserver://mssql:1433;database=master;user=SA;password=Pr1sm4_Pr1sm4;trustServerCertificate=true; | |
| - TEST_MSSQL_JDBC_URI=sqlserver://mssql:1433;database=master;user=SA;password=Pr1sm4_Pr1sm4;trustServerCertificate=true |
There was a problem hiding this comment.
I don't think it matters?
janpio
reviewed
Aug 13, 2021
packages/migrate/src/__tests__/fixtures/schema-only-sqlserver/prisma/invalid-url.prisma
Outdated
Show resolved
Hide resolved
…prisma/invalid-url.prisma Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
millsp
approved these changes
Aug 16, 2021
Jolg42
added a commit
that referenced
this pull request
Aug 18, 2021
* main: chore(deps): update engines to 2.30.0-15.4da3a4b94c0bc4080d9bca0c9af0ed6835b11a68 (#8800) chore(deps): update engines to 2.30.0-14.bc8ecb93b05fdd02e398f68b1ec6f66df813b1c6 (#8798) ci: switch engine type for both cli and client for relavant tests (#8782) fix(deps): update dependencies (non-major) (#8793) chore(deps): update react-prisma chore(deps): update engines to 2.30.0-13.9bcc8544c6e8000eadc8afce064b55d00b56ce28 (#8794) chore(deps): update jest (#8791) chore(deps): update devdependencies (non-major) (#8790) chore(deps): update engines to 2.30.0-12.bea9c1f215004e5407a7c5f77287b8bd5a24ea3c (#8785) chore(deps): update engines to 2.30.0-11.efdfe2be6801d76e59e7488f5bc60cece4e366d9 (#8780) chore(deps): update dependency @prisma/studio-server to v0.421.0 (#8767) chore(deps): update engines to 2.30.0-10.0210b3de5042a714f8838a59f9edcb28b11ab97d (#8778) chore(deps): update engines to 2.30.0-9.a8608ff20d8774e88657834d2d58ad4c9134e5b7 (#8769) chore: remove encrypt=DANGER_PLAINTEXT (#8737)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related prisma/docs#2090
Only used in tests an not needed anymore.