Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update undici to 4.4.6 #8831

Merged
merged 4 commits into from
Aug 20, 2021
Merged

fix(deps): update undici to 4.4.6 #8831

merged 4 commits into from
Aug 20, 2021

Conversation

janpio
Copy link
Member

@janpio janpio commented Aug 19, 2021

@janpio janpio mentioned this pull request Aug 19, 2021
Closed
@Jolg42 Jolg42 changed the title fix(deps): update unidici fix(deps): update undici Aug 20, 2021
@janpio janpio marked this pull request as ready for review August 20, 2021 13:24
Jolg42
Jolg42 suggested changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to either publish the package temporarily somewhere on npm or wait for a new undici release.

@ronag
Copy link

ronag commented Aug 20, 2021 •
edited
Loading

4.4.6 published for you

@matthewmueller matthewmueller mentioned this pull request Aug 20, 2021
Closed
@janpio janpio changed the title fix(deps): update undici fix(deps): update undici to 4.4.6 Aug 20, 2021
@Jolg42
Copy link
Contributor

Jolg42 commented Aug 20, 2021

And it works! Thank you @ronag!

@janpio janpio merged commit 6079f14 into integration/undici-4 Aug 20, 2021
@janpio janpio deleted the janpio/undici-lazy branch August 20, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jolg42 Jolg42 Jolg42 requested changes

@millsp millsp Awaiting requested review from millsp

@williamluke4 williamluke4 Awaiting requested review from williamluke4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@janpio @ronag @Jolg42