Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(db seed): GA - remove --preview-feature #9089

Merged
merged 6 commits into from Sep 3, 2021
Merged

fix(db seed): GA - remove --preview-feature #9089

merged 6 commits into from Sep 3, 2021

Conversation

Jolg42
Copy link
Member

@Jolg42 Jolg42 commented Sep 2, 2021 •
edited

Related #8732

@Jolg42 Jolg42 added this to the 2.31.0 / 3.0.x milestone Sep 2, 2021
@Jolg42 Jolg42 self-assigned this Sep 2, 2021
@Jolg42 Jolg42 marked this pull request as ready for review September 3, 2021 06:39
@Jolg42 Jolg42 requested a review from millsp as a code owner September 3, 2021 06:39
@Jolg42 Jolg42 requested a review from tomhoule September 3, 2021 06:55
tomhoule
tomhoule approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the context about the changes :)

@Jolg42 Jolg42 merged commit 9b94da0 into main Sep 3, 2021
@Jolg42 Jolg42 deleted the pr/db-seed-ga branch September 3, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpio janpio janpio left review comments

@tomhoule tomhoule tomhoule approved these changes

@millsp millsp Awaiting requested review from millsp

Assignees

@Jolg42 Jolg42

Labels
None yet
Projects
None yet
Milestone
2.31.0 / 3.0.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jolg42 @janpio @tomhoule