Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @prisma/studio-server to v0.426.0 #9244

Merged
merged 6 commits into from Sep 20, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 14, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@prisma/studio-server 0.423.0 -> 0.426.0 age adoption passing confidence

Configuration

πŸ“… Schedule: At any time (no schedule defined).

🚦 Automerge: Enabled.

β™» Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@sdnts
Copy link
Contributor

sdnts commented Sep 14, 2021

Keeping this PR open. It should keep failing, so it shouldn;t get merged. I'll debug here in a bit.

@renovate renovate bot force-pushed the renovate/studio branch 10 times, most recently from 04ecc8e to 812fdaa Compare September 17, 2021 19:04
@Jolg42
Copy link
Member

Jolg42 commented Sep 20, 2021

Esbuild failing for CLI with

> prisma@0.0.0 build /home/runner/work/prisma/prisma/packages/cli
> node helpers/build.js

 > scripts/preinstall.js:107:14: warning: This call to "require" will not be bundled because the argument is not a string literal (surround with a try/catch to silence this warning)
    107 β”‚   const pkg = require(installedGlobally.pkgPath)
        β•΅               ~~~~~~~

1 warning
 > ../../node_modules/.pnpm/@prisma+studio-pcw@0.426.0/node_modules/@prisma/studio-pcw/dist/utils/prismaEngineName.js:4:22: error: Could not resolve "@prisma/sdk" (mark it as external to exclude it from the bundle)
    4 β”‚ const sdk_1 = require("@prisma/sdk");
      β•΅                       ~~~~~~~~~~~~~

 > ../../node_modules/.pnpm/@prisma+studio-pcw@0.426.0/node_modules/@prisma/studio-pcw/dist/utils/loadEnvironment.js:5:22: error: Could not resolve "@prisma/sdk" (mark it as external to exclude it from the bundle)
    5 β”‚ const sdk_1 = require("@prisma/sdk");
      β•΅                       ~~~~~~~~~~~~~

 > ../../node_modules/.pnpm/@prisma+studio-pcw@0.426.0/node_modules/@prisma/studio-pcw/dist/client.js:11:174: warning: This call to "require" will not be bundled because the argument is not a string literal (surround with a try/catch to silence this warning)
    11 β”‚ ...maClientValidationError, } = require(`${paths.prismaClient}/runti...
       β•΅                                 ~~~~~~~

 > ../../node_modules/.pnpm/@prisma+studio-pcw@0.426.0/node_modules/@prisma/studio-pcw/dist/dmmf.js:6:40: warning: This call to "require" will not be bundled because the argument is not a string literal (surround with a try/catch to silence this warning)
    6 β”‚ ...{ externalToInternalDmmf, } = require(`${paths.prismaClient}/gener...
      β•΅                                  ~~~~~~~

 > ../../node_modules/.pnpm/@prisma+studio-pcw@0.426.0/node_modules/@prisma/studio-pcw/dist/generators.js:4:22: error: Could not resolve "@prisma/sdk" (mark it as external to exclude it from the bundle)
    4 β”‚ const sdk_1 = require("@prisma/sdk");
      β•΅                       ~~~~~~~~~~~~~

 > ../../node_modules/.pnpm/express@4.17.1/node_modules/express/lib/view.js:81:13: warning: This call to "require" will not be bundled because the argument is not a string literal (surround with a try/catch to silence this warning)
    81 β”‚     var fn = require(mod).__express
       β•΅              ~~~~~~~

 > ../../node_modules/.pnpm/@prisma+studio-pcw@0.426.0/node_modules/@prisma/studio-pcw/dist/utils/getPlatform.js:4:22: error: Could not resolve "@prisma/sdk" (mark it as external to exclude it from the bundle)
    4 β”‚ const sdk_1 = require("@prisma/sdk");
      β•΅                       ~~~~~~~~~~~~~

3 warnings and 4 errors
Error: Build failed with 4 errors:
../../node_modules/.pnpm/@prisma+studio-pcw@0.426.0/node_modules/@prisma/studio-pcw/dist/generators.js:4:22: error: Could not resolve "@prisma/sdk" (mark it as external to exclude it from the bundle)
../../node_modules/.pnpm/@prisma+studio-pcw@0.426.0/node_modules/@prisma/studio-pcw/dist/utils/getPlatform.js:4:22: error: Could not resolve "@prisma/sdk" (mark it as external to exclude it from the bundle)
../../node_modules/.pnpm/@prisma+studio-pcw@0.426.0/node_modules/@prisma/studio-pcw/dist/utils/loadEnvironment.js:5:22: error: Could not resolve "@prisma/sdk" (mark it as external to exclude it from the bundle)
../../node_modules/.pnpm/@prisma+studio-pcw@0.426.0/node_modules/@prisma/studio-pcw/dist/utils/prismaEngineName.js:4:22: error: Could not resolve "@prisma/sdk" (mark it as external to exclude it from the bundle)
    at failureErrorWithLog (/home/runner/work/prisma/prisma/node_modules/.pnpm/esbuild@0.8.53/node_modules/esbuild/lib/main.js:1177:15)
    at buildResponseToResult (/home/runner/work/prisma/prisma/node_modules/.pnpm/esbuild@0.8.53/node_modules/esbuild/lib/main.js:913:32)
    at /home/runner/work/prisma/prisma/node_modules/.pnpm/esbuild@0.8.53/node_modules/esbuild/lib/main.js:1008:20
    at /home/runner/work/prisma/prisma/node_modules/.pnpm/esbuild@0.8.53/node_modules/esbuild/lib/main.js:559:9
    at handleIncomingPacket (/home/runner/work/prisma/prisma/node_modules/.pnpm/esbuild@0.8.53/node_modules/esbuild/lib/main.js:648:9)
    at Socket.readFromStdout (/home/runner/work/prisma/prisma/node_modules/.pnpm/esbuild@0.8.53/node_modules/esbuild/lib/main.js:526:7)
    at Socket.emit (events.js:314:20)
    at addChunk (_stream_readable.js:297:12)
    at readableAddChunk (_stream_readable.js:272:9)
    at Socket.Readable.push (_stream_readable.js:213:10) {
  errors: [
    {
      detail: undefined,
      location: [Object],
      notes: [],
      text: 'Could not resolve "@prisma/sdk" (mark it as external to exclude it from the bundle)'
    },
    {
      detail: undefined,
      location: [Object],
      notes: [],
      text: 'Could not resolve "@prisma/sdk" (mark it as external to exclude it from the bundle)'
    },
    {
      detail: undefined,
      location: [Object],
      notes: [],
      text: 'Could not resolve "@prisma/sdk" (mark it as external to exclude it from the bundle)'
    },
    {
      detail: undefined,
      location: [Object],
      notes: [],
      text: 'Could not resolve "@prisma/sdk" (mark it as external to exclude it from the bundle)'
    }
  ],

@sdnts
Copy link
Contributor

sdnts commented Sep 20, 2021

Yeah I have no idea why. SDK is a peer dependency in both studio-server & studio-pcw (which is required by studio-server), so it is up to the CLI to provide it. SDK is for sure in this repo (and a dependency of the CLI), sooo?

FWIW, it was working up until now because the sdk was a dependency of studio-server, which was accidental.

@Jolg42
Copy link
Member

Jolg42 commented Sep 20, 2021

Waiting for integration run to see if that actually works like expected.

@sdnts
Copy link
Contributor

sdnts commented Sep 20, 2021

I checked, it seems to be fine!

@Jolg42
Copy link
Member

Jolg42 commented Sep 20, 2021

tests are failing in e2e but partially, looks like some parallel test issue
https://github.com/prisma/e2e-tests/runs/3653126232?check_suite_focus=true

npx prisma@3.1.0-integration-studio-cli-esbuild-plugin.1 studio seems to work though

Going to merge and see what needs to happen in e2e test after that.

Copy link
Member

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @madebysid ! <3

@Jolg42 Jolg42 added this to the 3.1.0 milestone Sep 20, 2021
@Jolg42 Jolg42 merged commit d75d71e into main Sep 20, 2021
@Jolg42 Jolg42 deleted the renovate/studio branch September 20, 2021 16:13
Jolg42 added a commit that referenced this pull request Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants