fix: emitted patterns for engine resolution #9295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, these lines resulted in the following to be emitted: ```js const dirname = findSync(process.cwd(), [ '"node_modules/.prisma/client"', '".prisma/client"', ], ['d'], ['d'], 1)[0] || __dirname ``` There's one pair of quotes too much, which causes `findSync` to not find anything. Since `dirname` is used to resolve the location of the Prisma engine, it's important that it is passed correct parameters. This can be fixed by removing the outer quotes, as `JSON.stringify` will already emit the double-quotes that mark it as a string literal. Related to netlify/zip-it-and-ship-it#630.
netlify-team-account-1
requested review from
Jolg42 and
millsp
as code owners
|
|
netlify-team-account-1
changed the title
netlify-team-account-1
changed the title
|
Nice catch and thanks for the PR! |
millsp
approved these changes
Sep 17, 2021
|
#8698 well I guess I can close mine then |
This was referenced Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prisma generatecurrently results in these lines to be emitted:There's one pair of quotes too much, which causes
findSyncto not find anything. Sincedirnameis used to resolve the location of the Prisma engine, it's important that it is passed correct parameters. At the moment, it will never find anything and resort to__dirname, breaking deploy for some bundlers.This can be fixed by removing the outer quotes, as
JSON.stringifywill already emit the double-quotes that mark it as a string literal.See netlify/zip-it-and-ship-it#630 for reference.