Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm install -g prisma2 also downloads migration engine, but doesn't mention it #507

Closed
janpio opened this issue Sep 6, 2019 · 4 comments
Assignees
Labels
kind/improvement An improvement to existing feature and code.
Milestone

Comments

@janpio
Copy link
Contributor

janpio commented Sep 6, 2019

During npm install -g prisma2 both the query engine and migration engine are downloaded but only the query engine gets a progress bar and output:

C:\Users\Jan\scoop\apps\nvm\current\nodejs\nodejs\node_modules\prisma2>dir
 Volume in drive C is Windows
 Volume Serial Number is DE17-D63A

 Directory of C:\Users\Jan\scoop\apps\nvm\current\nodejs\nodejs\node_modules\prisma2

06/09/2019  09:07    <DIR>          .
06/09/2019  09:07    <DIR>          ..
06/09/2019  09:06    <DIR>          build
06/09/2019  09:06    <DIR>          download-build
06/09/2019  09:06    <DIR>          nexus_prisma_ncc_build
06/09/2019  09:06             3.432 package.json
16/08/2019  15:48               759 README.md
06/09/2019  09:06    <DIR>          runtime
               2 File(s)          4.191 bytes
               6 Dir(s)  35.988.230.144 bytes free

C:\Users\Jan\scoop\apps\nvm\current\nodejs\nodejs\node_modules\prisma2>node download-build/index.js
> Downloading linux-glibc-libssl1.1.0 binary [====================] 100%


C:\Users\Jan\scoop\apps\nvm\current\nodejs\nodejs\node_modules\prisma2>dir
 Volume in drive C is Windows
 Volume Serial Number is DE17-D63A

 Directory of C:\Users\Jan\scoop\apps\nvm\current\nodejs\nodejs\node_modules\prisma2

06/09/2019  09:07    <DIR>          .
06/09/2019  09:07    <DIR>          ..
06/09/2019  09:06    <DIR>          build
06/09/2019  09:06    <DIR>          download-build
05/09/2019  23:56        14.753.856 migration-engine
06/09/2019  09:06    <DIR>          nexus_prisma_ncc_build
06/09/2019  09:06             3.432 package.json
05/09/2019  23:56        21.710.440 query-engine-linux-glibc-libssl1.1.0
16/08/2019  15:48               759 README.md
06/09/2019  09:06    <DIR>          runtime
               4 File(s)     36.468.487 bytes
               6 Dir(s)  35.970.285.568 bytes free

C:\Users\Jan\scoop\apps\nvm\current\nodejs\nodejs\node_modules\prisma2>

(This show the manual invocation of the same script that is also run during npm install -g)

(It also a bit confusing that the local file has a different name than what was downloaded - but maybe this is also the reason for my confusion here.)

@kaienbcjdoapwkfldue
Copy link

I would also suggest to rename the query engine binary from prisma.gz to query-engine-xyz.gz in the downloaded gzip file.

@pantharshit00 pantharshit00 added bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. labels Sep 6, 2019
@janpio
Copy link
Contributor Author

janpio commented Sep 6, 2019

Best open a new issue for this @kaienbcjdoapwkfldue - the filename that is being downloaded and being extracted to are important topic we should explicitly track - thanks for bringing this up!

@janpio janpio added process/candidate kind/improvement An improvement to existing feature and code. and removed bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. labels Sep 27, 2019
@janpio janpio added this to the Preview 14 milestone Sep 27, 2019
@timsuchanek
Copy link
Contributor

Released in the latest preview.

@janpio
Copy link
Contributor Author

janpio commented Oct 15, 2019

Did we lose the filename information this was? Are we ok with that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement An improvement to existing feature and code.
Projects
None yet
Development

No branches or pull requests

4 participants