This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
Visitor should never panic. #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
pimeys
force-pushed
the
remove-visitor-panics
branch
from
45ae0ed
to
37b0192
Compare
tomhoule
approved these changes
Jun 19, 2020
pimeys
force-pushed
the
remove-visitor-panics
branch
from
37b0192
to
1f5289f
Compare
tomhoule
approved these changes
Jun 19, 2020
| Err(Error::builder(kind).build())? | ||
| } | ||
| None => Value::Integer(None), | ||
| }, |
There was a problem hiding this comment.
Yeah. Not perfect, but at least better...
| fn is_json(&self) -> bool; | ||
| fn is_enum(&self) -> bool; | ||
| fn is_null(&self) -> bool; | ||
| } |
There was a problem hiding this comment.
I tried to use these with pg, but it doesn't really fit there that well...
pimeys
force-pushed
the
remove-visitor-panics
branch
from
1f5289f
to
af99a3b
Compare
pimeys
pushed a commit
to prisma/prisma-engines
that referenced
this pull request
Jun 19, 2020
pimeys
pushed a commit
to prisma/prisma-engines
that referenced
this pull request
Jun 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses (at least) these issues: