Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Removal of panics #137

Closed
pimeys opened this issue May 28, 2020 · 0 comments · Fixed by #146
Closed

Removal of panics #137

pimeys opened this issue May 28, 2020 · 0 comments · Fixed by #146
Assignees
Labels
kind/improvement An improvement to existing feature and code.
Milestone

Comments

@pimeys
Copy link
Contributor

pimeys commented May 28, 2020

With the upcoming changes for mssql, we get result types in the visitors and don't need to panic anymore in cases where user wants to use types such as Array in databases that do not support them (everything else except PostgreSQL).

Remove all places of panic!, unimplemented! etc. and replace them with proper error types.

@pimeys pimeys added the kind/improvement An improvement to existing feature and code. label May 28, 2020
@pimeys pimeys added this to the Beta 7 milestone May 28, 2020
@janpio janpio modified the milestones: Beta 7, Beta 8 May 29, 2020
@pimeys pimeys self-assigned this Jun 18, 2020
@pimeys pimeys modified the milestones: Beta 10, 2.1.0 Jun 18, 2020
@pimeys pimeys linked a pull request Jun 18, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/improvement An improvement to existing feature and code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants