Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Limit allocations when visiting queries #23

Merged
merged 2 commits into from
Nov 1, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ast/compare.rs
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ pub trait Comparable<'a> {
/// let query = Select::from_table("users").so_that("foo".in_selection(vec![1, 2]));
/// let (sql, params) = Sqlite::build(query);
///
/// assert_eq!("SELECT `users`.* FROM `users` WHERE `foo` IN (?, ?)", sql);
/// assert_eq!("SELECT `users`.* FROM `users` WHERE `foo` IN (?,?)", sql);
/// assert_eq!(vec![
/// ParameterizedValue::Integer(1),
/// ParameterizedValue::Integer(2),
Expand All @@ -210,7 +210,7 @@ pub trait Comparable<'a> {
/// let query = Select::from_table("users").so_that("foo".not_in_selection(vec![1, 2]));
/// let (sql, params) = Sqlite::build(query);
///
/// assert_eq!("SELECT `users`.* FROM `users` WHERE `foo` NOT IN (?, ?)", sql);
/// assert_eq!("SELECT `users`.* FROM `users` WHERE `foo` NOT IN (?,?)", sql);
///
/// assert_eq!(vec![
/// ParameterizedValue::Integer(1),
Expand Down
3 changes: 2 additions & 1 deletion src/ast/function/aggregate_to_string.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ pub struct AggregateToString<'a> {
/// # use prisma_query::{ast::*, visitor::{Visitor, Sqlite}};
/// let query = Select::from_table("users").value(aggregate_to_string(Column::new("firstName")))
/// .group_by("firstName");
///
/// let (sql, _) = Sqlite::build(query);
/// assert_eq!("SELECT group_concat(`firstName`) FROM `users` GROUP BY `firstName`", sql);
/// assert_eq!("SELECT GROUP_CONCAT(`firstName`) FROM `users` GROUP BY `firstName`", sql);
/// ```
#[inline]
pub fn aggregate_to_string<'a, T>(expr: T) -> AggregateToString<'a>
Expand Down
2 changes: 1 addition & 1 deletion src/connector/mysql.rs
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ VALUES (1, 'Joe', 27, 20000.00 );
config.db_name(Some("this_does_not_exist"));

let conn = Mysql::new(config).unwrap();
let res = conn.query_raw( "SELECT 1 + 1", &[]).await;
let res = conn.query_raw("SELECT 1 + 1", &[]).await;

assert!(&res.is_err());

Expand Down
Loading