Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add custom-timeout example #205

Merged
merged 1 commit into from
Jan 6, 2022
Merged

chore: add custom-timeout example #205

merged 1 commit into from
Jan 6, 2022

Conversation

angeloashmore
Copy link
Member

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR adds an example demonstrating how to add a custom request timeout duration. It implements it using an AbortController and setTimeout().

See: #129

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

🐢

@lihbr
Copy link
Member

lihbr commented Jan 6, 2022

Looks good to me, since fetch implementation can now be provided it's now the duty of the fetch implementation to handle any kind of timeout.

Moving forward with it 🚀

@lihbr lihbr merged commit d4e55d4 into master Jan 6, 2022
@lihbr lihbr deleted the aa/timeout-example branch January 6, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants