-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add play script
#1327
Merged
Merged
chore: add play script
#1327
Changes from 14 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
1c56c66
feat: add initial playground script
angeloashmore 7282e6a
chore: rebuild yarn.lock without playground deps
angeloashmore 66cb48b
refactor: script
angeloashmore 669033f
feat: try to make playgrounds isolated
angeloashmore d75188f
Merge branch 'main' into aa/playground-script
angeloashmore 65e35df
feat: add `play` CLI
angeloashmore 1a715a2
fix: pass dry run arg to `updateJSONFile`
angeloashmore b216ced
fix: ignore yarn.lock
angeloashmore fe7fb5b
refactor: review
angeloashmore 875cb28
fix: rename `playgroundRoot` to `playgroundDir`
angeloashmore 7986cc1
feat: support `--stage=<stage>`
angeloashmore ab16e49
feat: support Nuxt
angeloashmore 49e053d
fix: use a hardcoded api endpoint in nuxt websites
angeloashmore bfb737b
feat: add playground name to output
angeloashmore 78eff12
fix: use more compatible prefix styling
angeloashmore 8486926
fix: use shorter generated names
angeloashmore c19f3ab
fix: rename `--stage` to `--environment`
angeloashmore df727d7
feat: add `-e` alias for `--environment`
angeloashmore b50ba5c
refactor: use an explicit default `framework` value
angeloashmore ef47bbf
fix: per review
angeloashmore 55c535f
fix: remove unused `.yarnrc.yml` mention
angeloashmore 1dbcfbe
fix: remove origin from playground and commit changes
angeloashmore e34cc87
refactor: simplify `exec` overload
angeloashmore ce650e6
feat: use the local `@slicemachine/init`
angeloashmore a9ae332
fix: use constants everywhere (I forgot some)
angeloashmore File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Ignore everything... | ||
| * | ||
|
|
||
| # ...except the following files. | ||
| # They are necessary to isolate playgrounds and their dependencies from the monorepo. | ||
| !.gitignore | ||
| !yarnrc.yml | ||
| !package.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "packageManager": "yarn@3.6.0", | ||
| "private": true, | ||
| "workspaces": [ | ||
| "*" | ||
bapmrl marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ], | ||
| "resolutions": { | ||
bapmrl marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "@slicemachine/adapter-next": "link:../packages/adapter-next", | ||
bapmrl marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "@slicemachine/adapter-nuxt": "link:../packages/adapter-nuxt", | ||
| "@slicemachine/adapter-nuxt2": "link:../packages/adapter-nuxt2", | ||
| "@slicemachine/adapter-sveltekit": "link:../packages/adapter-sveltekit", | ||
| "@slicemachine/init": "link:../packages/init", | ||
| "@slicemachine/manager": "link:../packages/manager", | ||
| "@slicemachine/plugin-kit": "link:../packages/plugin-kit", | ||
| "slice-machine-ui": "link:../packages/slice-machine", | ||
| "start-slicemachine": "link:../packages/start-slicemachine" | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cleanscript?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could, but I wonder if we should ask for confirmation before deleting all playgrounds. It's possible a playground could contain a lot of work or a specific set up, and I wouldn't want someone to accidentally lose it all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could create a simple custom
scripts/clean.tswith a prompt?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, you're right. We'll probably have changes we don't want to lose.
Consequently, I think we can either:
cleanscript so that it only deletes well known build/cache directories in the playgrounds. For example, it could delete the nested.nextdirectories. Of course, it shouldn't accidentally delete content in theplaygrounds/node_modulesdirectory or other configuration files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To expedite merging this PR, let's not change the
cleanscript for now. We can revisit it in a future PR. I like the second idea, perhaps in addition to the ability to delete playgrounds.